Skip to content

Commit 71b79da

Browse files
committed
PRD: cleaned procedure callouts in prdfCalloutMap.H
Change-Id: I9b645205bc2efeb269a025d4077ea0cde003b046 RTC: 137911 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37308 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com> Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37602 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
1 parent b6865c1 commit 71b79da

18 files changed

+50
-60
lines changed

src/usr/diag/prdf/common/framework/resolution/prdfCalloutMap.H

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,14 @@ namespace PRDF
8282

8383
PRDF_SYM_CALLOUT_MAP_BEGIN
8484

85-
PRDF_SYM_CALLOUT_ALIAS( AllProcessors, HWAS::EPUB_PRC_ALL_PROCS )
86-
PRDF_SYM_CALLOUT_ALIAS( SP_CODE, HWAS::EPUB_PRC_SP_CODE )
87-
PRDF_SYM_CALLOUT_ALIAS( SystemSW_Code_ENUM, HWAS::EPUB_PRC_PHYP_CODE )
88-
PRDF_SYM_CALLOUT_ALIAS( NextLevelSupport_ENUM, HWAS::EPUB_PRC_LVL_SUPP )
89-
PRDF_SYM_CALLOUT_ALIAS( PassiveFabric_OffNode_ENUM, HWAS::EPUB_PRC_PROC_AB_BUS )
90-
PRDF_SYM_CALLOUT_ALIAS( ErrorCausedByMemUE_ENUM, HWAS::EPUB_PRC_MEMORY_UE )
91-
PRDF_SYM_CALLOUT_ALIAS( TODProcInterface_Enum, HWAS::EPUB_PRC_TOD_CLOCK_ERR )
92-
PRDF_SYM_CALLOUT_ALIAS( CoolingSystemError_ENUM, HWAS::EPUB_PRC_COOLING_SYSTEM_ERR)
85+
PRDF_SYM_CALLOUT_ALIAS( SUE_PREV_ERR, HWAS::EPUB_PRC_SUE_PREVERROR )
86+
PRDF_SYM_CALLOUT_ALIAS( SP_CODE, HWAS::EPUB_PRC_SP_CODE )
87+
PRDF_SYM_CALLOUT_ALIAS( SYS_SW_CODE, HWAS::EPUB_PRC_PHYP_CODE )
88+
PRDF_SYM_CALLOUT_ALIAS( LEVEL2_SUPPORT, HWAS::EPUB_PRC_LVL_SUPP )
89+
PRDF_SYM_CALLOUT_ALIAS( FAB_BUS_OFF_NODE, HWAS::EPUB_PRC_PROC_AB_BUS )
90+
PRDF_SYM_CALLOUT_ALIAS( ERR_ROOT_IS_MEM_UE, HWAS::EPUB_PRC_MEMORY_UE )
91+
PRDF_SYM_CALLOUT_ALIAS( TOD_CLOCK_ERR, HWAS::EPUB_PRC_TOD_CLOCK_ERR )
92+
PRDF_SYM_CALLOUT_ALIAS( COOLING_SYSTEM_ERR, HWAS::EPUB_PRC_COOLING_SYSTEM_ERR)
9393

9494
PRDF_SYM_CALLOUT_MAP_END
9595

src/usr/diag/prdf/common/framework/service/xspprdsdbug.C

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,7 @@ uint32_t SYSTEM_DEBUG_CLASS::Reinitialize(const AttnList & i_attnList)
177177
0, // user data word 3
178178
0 ); // user data word 4
179179

180-
PRDF_ADD_PROCEDURE_CALLOUT( g_prd_errlHndl, MRU_MED,
181-
HWAS::EPUB_PRC_SP_CODE );
180+
PRDF_ADD_PROCEDURE_CALLOUT( g_prd_errlHndl, MRU_MED, SP_CODE );
182181
l_rc = PRD_ATTN_DATA_ACCESS_FAILED;
183182

184183
break;
@@ -330,7 +329,7 @@ void SYSTEM_DEBUG_CLASS::CalloutThoseAtAttention(
330329
capture.Add(PlatServices::getSystemTarget(),0,cbs);
331330
}
332331

333-
sdc->SetCallout(NextLevelSupport_ENUM, MRU_HIGH);
332+
sdc->SetCallout(LEVEL2_SUPPORT, MRU_HIGH);
334333
}
335334

336335
// -------------------------------------------------------------------

src/usr/diag/prdf/common/plat/p9/p9_common_actions.rule

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,10 @@ actionclass calloutSelfLow { callout(MRU_LOW); };
126126

127127
# 2nd Level Support
128128
actionclass callout2ndLvlMed
129-
{ callout(procedure(NextLevelSupport_ENUM), MRU_MED); };
129+
{ callout(procedure(LEVEL2_SUPPORT), MRU_MED); };
130130

131131
actionclass callout2ndLvlLow
132-
{ callout(procedure(NextLevelSupport_ENUM), MRU_LOW); };
132+
{ callout(procedure(LEVEL2_SUPPORT), MRU_LOW); };
133133

134134
/** Callout self with medium priority but don't gard it */
135135
actionclass calloutSelfMedNoGard

src/usr/diag/prdf/common/plat/p9/prdfP9PllDomain.C

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,13 +279,13 @@ int32_t PllDomain::Analyze(STEP_CODE_DATA_STRUCT & serviceData,
279279
{
280280
PRDF_ERR( PRDF_FUNC "Unexpected PCI osc failover detected" );
281281
mskErrType |= PCI_OSC_FAILOVER;
282-
serviceData.service_data->SetCallout( NextLevelSupport_ENUM, MRU_LOW );
282+
serviceData.service_data->SetCallout( LEVEL2_SUPPORT, MRU_LOW );
283283
}
284284
if (sysRefFoList.size() > 0)
285285
{
286286
PRDF_ERR( PRDF_FUNC "Unexpected Sys osc failover detected" );
287287
mskErrType |= SYS_OSC_FAILOVER;
288-
serviceData.service_data->SetCallout( NextLevelSupport_ENUM, MRU_LOW );
288+
serviceData.service_data->SetCallout( LEVEL2_SUPPORT, MRU_LOW );
289289
}
290290

291291
if (serviceData.service_data->IsAtThreshold())

src/usr/diag/prdf/common/plat/pegasus/Proc_acts_ABUS.rule

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#
66
# OpenPOWER HostBoot Project
77
#
8-
# Contributors Listed Below - COPYRIGHT 2012,2015
8+
# Contributors Listed Below - COPYRIGHT 2012,2017
99
# [+] International Business Machines Corp.
1010
#
1111
#
@@ -521,7 +521,7 @@ group gIoaFir filter singlebit,
521521
/** Callout the ABUS 0 interface */
522522
actionclass calloutAbus0Interface
523523
{
524-
callout(procedure(PassiveFabric_OffNode_ENUM), MRU_MED);
524+
callout(procedure(FAB_BUS_OFF_NODE), MRU_MED);
525525
callout(connected(TYPE_ABUS, 0), MRU_MEDA);
526526
callout(connected_peer(TYPE_ABUS, 0), MRU_MEDA);
527527
funccall("calloutInterface_abus0");
@@ -530,7 +530,7 @@ actionclass calloutAbus0Interface
530530
/** Callout the ABUS 1 interface */
531531
actionclass calloutAbus1Interface
532532
{
533-
callout(procedure(PassiveFabric_OffNode_ENUM), MRU_MED);
533+
callout(procedure(FAB_BUS_OFF_NODE), MRU_MED);
534534
callout(connected(TYPE_ABUS, 1), MRU_MEDA);
535535
callout(connected_peer(TYPE_ABUS, 1), MRU_MEDA);
536536
funccall("calloutInterface_abus1");
@@ -539,7 +539,7 @@ actionclass calloutAbus1Interface
539539
/** Callout the ABUS 2 interface */
540540
actionclass calloutAbus2Interface
541541
{
542-
callout(procedure(PassiveFabric_OffNode_ENUM), MRU_MED);
542+
callout(procedure(FAB_BUS_OFF_NODE), MRU_MED);
543543
callout(connected(TYPE_ABUS, 2), MRU_MEDA);
544544
callout(connected_peer(TYPE_ABUS, 2), MRU_MEDA);
545545
funccall("calloutInterface_abus2");

src/usr/diag/prdf/common/plat/pegasus/Proc_acts_TP.rule

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#
66
# OpenPOWER HostBoot Project
77
#
8-
# Contributors Listed Below - COPYRIGHT 2012,2016
8+
# Contributors Listed Below - COPYRIGHT 2012,2017
99
# [+] International Business Machines Corp.
1010
#
1111
#
@@ -1314,7 +1314,7 @@ actionclass analyzePibError
13141314
/** Callout the cooling system error procedure */
13151315
actionclass coolingSystemError
13161316
{
1317-
callout(procedure(CoolingSystemError_ENUM), MRU_MED);
1317+
callout(procedure(COOLING_SYSTEM_ERR), MRU_MED);
13181318
threshold1;
13191319
};
13201320

src/usr/diag/prdf/common/plat/pegasus/prdfCalloutUtil.C

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/* */
66
/* OpenPOWER HostBoot Project */
77
/* */
8-
/* Contributors Listed Below - COPYRIGHT 2012,2016 */
8+
/* Contributors Listed Below - COPYRIGHT 2012,2017 */
99
/* [+] International Business Machines Corp. */
1010
/* */
1111
/* */
@@ -48,7 +48,7 @@ namespace CalloutUtil
4848

4949
void defaultError( STEP_CODE_DATA_STRUCT & i_sc )
5050
{
51-
i_sc.service_data->SetCallout( NextLevelSupport_ENUM, MRU_MED, NO_GARD );
51+
i_sc.service_data->SetCallout( LEVEL2_SUPPORT, MRU_MED, NO_GARD );
5252
i_sc.service_data->SetCallout( SP_CODE, MRU_MED, NO_GARD );
5353
i_sc.service_data->setServiceCall();
5454
}

src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaTdCtlr_common.C

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ void CenMbaTdCtlrCommon::badPathErrorHandling( STEP_CODE_DATA_STRUCT & io_sc )
695695
io_sc.service_data->setServiceCall();
696696

697697
// There may have been a code bug, callout 2nd level support.
698-
io_sc.service_data->SetCallout( NextLevelSupport_ENUM, MRU_HIGH );
698+
io_sc.service_data->SetCallout( LEVEL2_SUPPORT, MRU_HIGH );
699699

700700
// Callout the rank if no other callouts have been made (besides 2nd
701701
// Level Support). Note that iv_mark is not always guaranteed to be

src/usr/diag/prdf/common/plat/pegasus/prdfCenMembuf.C

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1155,7 +1155,7 @@ int32_t internalTimeout( ExtensibleChip * i_mbChip,
11551155
else
11561156
{
11571157
// Make the callout of the external timeout error.
1158-
i_sc.service_data->SetCallout( NextLevelSupport_ENUM,
1158+
i_sc.service_data->SetCallout( LEVEL2_SUPPORT,
11591159
MRU_MED, NO_GARD );
11601160
}
11611161
}

src/usr/diag/prdf/common/plat/pegasus/prdfP8Proc.C

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/* */
66
/* OpenPOWER HostBoot Project */
77
/* */
8-
/* Contributors Listed Below - COPYRIGHT 2012,2016 */
8+
/* Contributors Listed Below - COPYRIGHT 2012,2017 */
99
/* [+] International Business Machines Corp. */
1010
/* */
1111
/* */
@@ -912,8 +912,7 @@ int32_t calloutPhb( ExtensibleChip * i_procChip, STEP_CODE_DATA_STRUCT & io_sc,
912912

913913
// If no PHBs called out, callout 2nd level support.
914914
if ( (SUCCESS != l_rc) || (0 == io_sc.service_data->getMruListSize()) )
915-
io_sc.service_data->SetCallout( NextLevelSupport_ENUM,
916-
MRU_MED, NO_GARD );
915+
io_sc.service_data->SetCallout( LEVEL2_SUPPORT, MRU_MED, NO_GARD );
917916

918917
return SUCCESS; // Intentionally returns SUCCESS so rule code does not get
919918
// confused by undefined error code.

0 commit comments

Comments
 (0)