Skip to content

Commit

Permalink
MDIA: Bumped MDIA timeout value becasue of Nimbus DD1.0 workaround
Browse files Browse the repository at this point in the history
Change-Id: Ic66bdfa666013079d52961aedbf6186574ab0dff
CQ: SW377891
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35619
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
  • Loading branch information
zane131 committed Jan 31, 2017
1 parent 080232a commit 7483710
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 15 deletions.
23 changes: 11 additions & 12 deletions src/usr/diag/mdia/mdiasm.C
Expand Up @@ -403,8 +403,8 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
// Committing an info log to help debug SW timeout
if((*wit)->timeoutCnt >= MAINT_CMD_TIMEOUT_LOG)
{
MDIA_FAST("sm: committing a SW timed out info log "
"for %x", get_huid(target));
MDIA_FAST("sm: committing a SW timeout info log "
"for HUID:0x%08X", get_huid(target));

/*@
* @errortype
Expand Down Expand Up @@ -435,9 +435,10 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
(*wit)->timeoutCnt++;
}

MDIA_FAST("sm: work item %d reset SW timed out on: %x, "
"timeoutCnt: %d", *((*wit)->workItem),
get_huid(target), (*wit)->timeoutCnt);
MDIA_FAST("sm: work item %d reset SW timed out on "
"HUID:0x%08X, timeoutCnt: %d",
*((*wit)->workItem), get_huid(target),
(*wit)->timeoutCnt);
// register a new timeout monitor
uint64_t monitorId =
getMonitor().addMonitor(MAINT_CMD_TIMEOUT);
Expand Down Expand Up @@ -472,7 +473,7 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
HWAS::GARD_NULL);

// If maint cmd complete bit is not on, time out
MDIA_FAST("sm: stopping command: %p", target);
MDIA_FAST("sm: stopping command HUID:0x%08X", get_huid(target));
//target type is MBA
if ( TYPE_MBA == trgtType )
{
Expand Down Expand Up @@ -535,10 +536,8 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs)
wkflprop = *wit;

// log a timeout event
MDIA_ERR("sm: command %p: %d HW timed out on: %x",
target,
*((*wit)->workItem),
get_huid(target));
MDIA_ERR("sm: workItem %d HW timeout on HUID:0x%08X",
*((*wit)->workItem), get_huid(target));

errlCommit(timeoutErrl, MDIA_COMP_ID);

Expand Down Expand Up @@ -746,7 +745,7 @@ bool StateMachine::scheduleWorkItem(WorkFlowProperties & i_wfp)

TargetHandle_t target = getTarget(i_wfp);

MDIA_FAST("sm: dispatching work item %d for: %p, priority: %d, "
MDIA_FAST("sm: dispatching work item %d for: 0x%08x, priority: %d, "
"unit: %d", *i_wfp.workItem,
get_huid(target),
priority,
Expand Down Expand Up @@ -802,7 +801,7 @@ bool StateMachine::executeWorkItem(WorkFlowProperties * i_wfp)

uint64_t workItem = *i_wfp->workItem;

MDIA_FAST("sm: executing work item %d for: %x",
MDIA_FAST("sm: executing work item %d for: 0x%08x",
workItem, get_huid(getTarget(*i_wfp)));

mutex_unlock(&iv_mutex);
Expand Down
9 changes: 6 additions & 3 deletions src/usr/diag/mdia/mdiasm.H
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2012,2016 */
/* Contributors Listed Below - COPYRIGHT 2012,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -41,8 +41,11 @@
namespace MDIA
{

//MBA timeout value - 30 secs
static const uint64_t MAINT_CMD_TIMEOUT = 30000000000;
// HW timeout value - 30 secs
// Nimbus DD1.0 has a workaround that will go over 30 seconds. Will need to bump
// it up for now. May consider lowering it later, but only if there is a
// problem.
static const uint64_t MAINT_CMD_TIMEOUT = 30000000000 * 10;

//Longer MBA timeout to be used when continuous tracing is enabled - 30 min
static const uint64_t MAINT_CMD_TIMEOUT_LONG = 1800000000000;
Expand Down

0 comments on commit 7483710

Please sign in to comment.