Skip to content

Commit

Permalink
Remove bring up workaround that disabled memory throttles
Browse files Browse the repository at this point in the history
Change-Id: I8816cda1dd5ec1a789048893e0eda73aad35a250
RTC:167292
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37587
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
sannerd authored and dcrowell77 committed Mar 17, 2017
1 parent 1700a42 commit 9a72ce9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 28 deletions.
24 changes: 0 additions & 24 deletions src/usr/isteps/istep13/call_mss_draminit_mc.C
Expand Up @@ -105,30 +105,6 @@ void* call_mss_draminit_mc (void *io_pArgs)
} // End; memBuf loop


//TODO RTC:167292 Remove this workaround that is clearing this scom register
uint64_t l_data64 = 0x0;
size_t l_size = sizeof(uint64_t);
// Get all MCAs
TARGETING::TargetHandleList l_mcaTargetList;
getAllChiplets(l_mcaTargetList, TYPE_MCA);

//Clear out the MBA_FARB3Q reg(0x7010916) on all MCAs
for (const auto & l_mca_target : l_mcaTargetList)
{
l_err = deviceOp( DeviceFW::WRITE,
l_mca_target,
&l_data64,
l_size,
DEVICE_SCOM_ADDRESS(0x7010916));
if (l_err)
{
TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
"Failed clearing MBA_FARB3Q register on MCA %d",
l_mca_target->getAttr<TARGETING::ATTR_CHIPLET_ID>());
errlCommit(l_err, HWPF_COMP_ID);
}
}

TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "call_mss_draminit_mc exit" );

return l_stepError.getErrorHandle();
Expand Down
10 changes: 6 additions & 4 deletions src/usr/targeting/common/genHwsvMrwXml.pl
Expand Up @@ -288,15 +288,17 @@
"SPIPSS_FREQUENCY", $reqPol->{'pm_spipss_frequency'}->{content},
"MEM_MIRROR_PLACEMENT_POLICY", $placement,
"MSS_MRW_DIMM_POWER_CURVE_PERCENT_UPLIFT",
$reqPol->{'dimm_power_curve_percent_uplift'},
$reqPol->{'mss_mrw_dimm_power_curve_percent_uplift'},
"MSS_MRW_DIMM_POWER_CURVE_PERCENT_UPLIFT_IDLE",
$reqPol->{'dimm_power_curve_percent_uplift_idle'},
$reqPol->{'mss_mrw_dimm_power_curve_percent_uplift_idle'},
"MRW_MEM_THROTTLE_DENOMINATOR",
$reqPol->{'mem_throttle_denominator'},
$reqPol->{'mss_mrw_mem_m_dram_clocks'},
"MSS_MRW_MAX_DRAM_DATABUS_UTIL",
$reqPol->{'max_dram_databus_util'},
$reqPol->{'mss_mrw_max_dram_databus_util'},
"MSS_MRW_MAX_NUMBER_DIMMS_POSSIBLE_PER_VMEM_REGULATOR",
$reqPol->{'mss_mrw_max_number_dimms_possible_per_vmem_regulator'},
"MSS_MRW_THERMAL_MEMORY_POWER_LIMIT",
$reqPol->{'mss_mrw_thermal_memory_power_limit'},
"SYSTEM_IVRMS_ENABLED", $reqPol->{'pm_system_ivrms_enabled'},
"PM_SYSTEM_IVRM_VPD_MIN_LEVEL", $reqPol->{'pm_system_ivrm_vpd_min_level'},
"MNFG_DMI_MIN_EYE_WIDTH", $reqPol->{'mnfg-dmi-min-eye-width'},
Expand Down

0 comments on commit 9a72ce9

Please sign in to comment.