Skip to content

Commit b04eb38

Browse files
premsjhadcrowell77
authored andcommitted
PM: Corrected byte alignment for CME repair ring.
Commit corrects the size calculation of ec_repr ring. Calculation was not accounting for placement at 8B boundary. As a result, in some cases, size of repair ring was populated with a value less than actual value leading to CME puting failure. Change-Id: I821b4ef7fdcd17fe616d27d581875ca2c465d5d9 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35780 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com> Reviewed-by: Brian T. Vanderpool <vanderp@us.ibm.com> Reviewed-by: Gregory S. Still <stillgs@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35784 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
1 parent ff7e940 commit b04eb38

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ extern "C"
6969
{ \
7070
(DATA_SIZE = DATA_SIZE + (RING_ALIGN_BOUNDARY - TEMP_LEN));\
7171
} \
72-
} \
72+
}
7373

7474
/**
7575
* @brief aligns start of scan ring to 8B boundary.
@@ -1526,6 +1526,7 @@ extern "C"
15261526
uint32_t maxCoreSpecRingLength = 0;
15271527
uint32_t ringLength = 0;
15281528
uint32_t tempSize = 0;
1529+
uint32_t tempRepairLength = 0;
15291530
uint32_t ringStartToHdrOffset = ( TOR_VER_ONE == P9_TOR::tor_version() ) ? RING_START_TO_RS4_OFFSET : 0;
15301531

15311532
do
@@ -1573,10 +1574,11 @@ extern "C"
15731574
continue;
15741575
}
15751576

1577+
ALIGN_DWORD(tempRepairLength, tempSize);
1578+
15761579
ringLength += tempSize;
15771580
}
15781581

1579-
ALIGN_DWORD(tempSize, ringLength)
15801582
maxCoreSpecRingLength = ringLength > maxCoreSpecRingLength ? ringLength : maxCoreSpecRingLength;
15811583
}
15821584

0 commit comments

Comments
 (0)