Skip to content

Commit

Permalink
PM: Corrected byte alignment for CME repair ring.
Browse files Browse the repository at this point in the history
Commit corrects the size calculation of ec_repr ring. Calculation
was not accounting for placement at 8B boundary. As a result, in some
cases, size of repair ring was populated with a value less than
actual value leading to CME puting failure.

Change-Id: I821b4ef7fdcd17fe616d27d581875ca2c465d5d9
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35780
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Brian T. Vanderpool <vanderp@us.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35784
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
premsjha authored and dcrowell77 committed Feb 7, 2017
1 parent ff7e940 commit b04eb38
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C
Expand Up @@ -69,7 +69,7 @@ extern "C"
{ \
(DATA_SIZE = DATA_SIZE + (RING_ALIGN_BOUNDARY - TEMP_LEN));\
} \
} \
}

/**
* @brief aligns start of scan ring to 8B boundary.
Expand Down Expand Up @@ -1526,6 +1526,7 @@ extern "C"
uint32_t maxCoreSpecRingLength = 0;
uint32_t ringLength = 0;
uint32_t tempSize = 0;
uint32_t tempRepairLength = 0;
uint32_t ringStartToHdrOffset = ( TOR_VER_ONE == P9_TOR::tor_version() ) ? RING_START_TO_RS4_OFFSET : 0;

do
Expand Down Expand Up @@ -1573,10 +1574,11 @@ extern "C"
continue;
}

ALIGN_DWORD(tempRepairLength, tempSize);

ringLength += tempSize;
}

ALIGN_DWORD(tempSize, ringLength)
maxCoreSpecRingLength = ringLength > maxCoreSpecRingLength ? ringLength : maxCoreSpecRingLength;
}

Expand Down

0 comments on commit b04eb38

Please sign in to comment.