Skip to content

Commit

Permalink
Quick fix to get boot side before SBE is started
Browse files Browse the repository at this point in the history
Code can attempt to get the boot side for an SBE before the SBE is
started and the SCOM can be read.  In this case the boot side for the
master processor should be used.  First step of this fix is to remove
the #if logic around the block to select the master processor target.

Change-Id: Idb08165a3e2c9217adc17592ffb56b9434182acd
Depends-on: I8111a40c8aa53e1699b0381440584db3dd6c3fc6
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35730
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
mgloff authored and wghoffa committed Feb 1, 2017
1 parent 6c70021 commit b14f1ac
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/usr/sbe/sbe_update.C
Expand Up @@ -1733,9 +1733,6 @@ namespace SBE

TARGETING::Target * l_target=i_target;

#if defined(CONFIG_SBE_UPDATE_INDEPENDENT) || \
defined(CONFIG_SBE_UPDATE_SIMULTANEOUS)

// Get the Master Proc Chip Target for comparisons later
TARGETING::Target* masterProcChipTargetHandle = NULL;
TargetService& tS = targetService();
Expand All @@ -1751,7 +1748,7 @@ namespace SBE
TARGETING::get_huid(l_target));

}
#endif

// Read PERV_SB_CS_SCOM 0x00050008
size_t op_size = sizeof(scomData);
err = deviceRead( l_target,
Expand Down

0 comments on commit b14f1ac

Please sign in to comment.