Skip to content

Commit

Permalink
Updated memory DD1 vs DD2 attribute
Browse files Browse the repository at this point in the history
Change-Id: Ie6d0f188a2ce94375535b0bf16c8ed1756558e5f
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40632
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40636
  • Loading branch information
sglancy6 authored and dcrowell77 committed May 25, 2017
1 parent 524c963 commit c2eb2c3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Expand Up @@ -80,7 +80,7 @@ fapi_try_exit:
}

///
/// @brief ATTR_CHIP_EC_FEATURE_MSS_UT_EC_NIMBUS_LESS_THAN_TWO_OH getter
/// @brief ATTR_CHIP_EC_FEATURE_MSS_NIMBUS_EC_LESS_THAN_TWO_OH getter
/// @tparam T the fapi2 target type of the target
/// @param[in] const ref to the target
/// @return bool true iff we're on a Nimbus < EC 2.0
Expand All @@ -91,12 +91,12 @@ inline bool chip_ec_nimbus_lt_2_0(const fapi2::Target<T>& i_target)
const auto l_chip = mss::find_target<fapi2::TARGET_TYPE_PROC_CHIP>(i_target);
uint8_t l_value = 0;

FAPI_TRY( FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_MSS_UT_EC_NIMBUS_LESS_THAN_TWO_OH, l_chip, l_value) );
FAPI_TRY( FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_MSS_NIMBUS_EC_LESS_THAN_TWO_OH, l_chip, l_value) );

return l_value != 0;

fapi_try_exit:
FAPI_ERR("failed accessing ATTR_CHIP_EC_FEATURE_MSS_UT_EC_NIMBUS_LESS_THAN_TWO_OH: 0x%lx (target: %s)",
FAPI_ERR("failed accessing ATTR_CHIP_EC_FEATURE_MSS_NIMBUS_EC_LESS_THAN_TWO_OH: 0x%lx (target: %s)",
uint64_t(fapi2::current_err), mss::c_str(i_target));
fapi2::Assert(false);
return false;
Expand Down
Expand Up @@ -2878,10 +2878,10 @@
</attribute>

<attribute>
<id>ATTR_CHIP_EC_FEATURE_MSS_UT_EC_NIMBUS_LESS_THAN_TWO_OH</id>
<id>ATTR_CHIP_EC_FEATURE_MSS_NIMBUS_EC_LESS_THAN_TWO_OH</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Attribute used only for memory subsystem unit tests. Tells us whether
Attribute used only for memory subsystem procedures. Tells us whether
the chip EC we're running on is less than 2.0 and we're on a Nimbus
</description>
<chipEcFeature>
Expand Down

0 comments on commit c2eb2c3

Please sign in to comment.