Skip to content

Commit

Permalink
Address minor comments from Story 175114
Browse files Browse the repository at this point in the history
Done separately in order to not restart CI on other commits

Change-Id: I02c91d15c7a58673ba9e3da67a61aee66a647915
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43034
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Stephen Cprek authored and dcrowell77 committed Jul 20, 2017
1 parent 781d316 commit c30be2b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/build/debug/Hostboot/Dump.pm
Expand Up @@ -41,7 +41,7 @@ use constant MEMSTATE_MS_32MEG => 0x20;
use constant _KB => 1024;
use constant _MB => 1024 * 1024;

# Size of HBB PNOR partition without ECC, page algined down, minus 4K header
# Size of HBB PNOR partition without ECC, page aligned down, minus 4K header
use constant MAX_HBB_SIZE => (904 * _KB);

# Map the available memory at each state.
Expand Down
4 changes: 2 additions & 2 deletions src/build/debug/fsp-memdump.sh
Expand Up @@ -117,14 +117,14 @@ HB_BASE_HRMOR=`expr 32 \* 1024 \* 1024 \* 1024 \* 1024`
HRMOR=`expr ${HB_BASE_HRMOR} \* ${NODE} + ${HB_OFFSET}`
echo "NODE: ${NODE} - HRMOR is: ${HRMOR}"

# Using initial STATE, iterate through all the included states dumping each's
# Using initial STATE, iterate through all the included states dumping each
# appropriate memory sections.
while [[ ${STATE} != BREAK ]]
do
# *** NOTE: Keep in sync with Dump.pm and bootloaderif.H (MAX_HBB_SIZE)
case ${STATE} in
00|0)
# Size of HBB PNOR partition without ECC, page algined down, minus 4K header
# Size of HBB PNOR partition without ECC, page aligned down, minus 4K header
dump 0 925696
STATE=BREAK
;;
Expand Down
1 change: 0 additions & 1 deletion src/usr/secureboot/base/service.C
Expand Up @@ -98,7 +98,6 @@ void* initializeBase(void* unused)
Singleton<Header>::instance().loadSecurely();
}

// Don't extend more than 1/2 cache in VPO as fake PNOR is there
// Don't enable SecureRomManager in VPO
#ifndef CONFIG_P9_VPO_COMPILE

Expand Down

0 comments on commit c30be2b

Please sign in to comment.