Skip to content

Commit

Permalink
p9_scominfo update cannot do a mask check with a mask value of 0's.
Browse files Browse the repository at this point in the history
Change-Id: I1fa87291b00ff5f2e912ddafe8e1bb8559d70233
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36559
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Dev-Ready: Brent Wieman <bwieman@us.ibm.com>
Reviewed-by: CHRISTINA L. GRAVES <clgraves@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Tested-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36599
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
BenAtIBM authored and dcrowell77 committed Feb 23, 2017
1 parent 1dcd6b8 commit c3170c0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/import/chips/p9/common/scominfo/p9_scominfo.C
Expand Up @@ -149,7 +149,7 @@ extern "C"
break;

case PU_NV_CHIPUNIT:
if ((i_mode & P9N_DD1_SI_MODE) == P9N_DD1_SI_MODE)
if (i_mode == P9N_DD1_SI_MODE)
{
l_scom.set_sat_id((l_scom.get_sat_id() % 4) + ((i_chipUnitNum / 2) * 4));
l_scom.set_sat_offset( (l_scom.get_sat_offset() % 32) +
Expand Down Expand Up @@ -562,7 +562,7 @@ extern "C"
}

// PU_NV_CHIPUNIT
if ((i_mode & P9N_DD1_SI_MODE) == P9N_DD1_SI_MODE)
if (i_mode == P9N_DD1_SI_MODE)
{
// See npu_misc_regs.vhdl, line 2710,
// sc_addr(0 to 6) represents sat_id(0..3) and sat_offset(0..2)
Expand Down

0 comments on commit c3170c0

Please sign in to comment.