Skip to content

Commit

Permalink
Added traces to figure out the infinite loop in the mpipl path
Browse files Browse the repository at this point in the history 
Change-Id: Iabe0a1ae22e0a18915a3ca645932e09b3bf83b28
CQ: SW386997
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41361
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41365
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
  • Loading branch information
@sgupta2m
Raja Das authored and sgupta2m committed Jun 6, 2017
1 parent 4e9be1e commit d1f28c8
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 5 deletions.
16 changes: 16 additions & 0 deletions src/import/chips/p9/procedures/hwp/nest/p9_sbe_check_quiesce.C
View file
Expand Up @@ -82,6 +82,7 @@ extern "C" {
fapi2::ReturnCode p9_sbe_check_quiesce(const
fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_sbe_check_quiesce: Entering..");
// mark HWP entry

// SBE will check quiesce state for all units on the powerbus on its chip
Expand Down Expand Up @@ -110,6 +111,7 @@ extern "C" {
}
}

FAPI_IMP("p9_sbe_check_quiesce: Exiting..");
return saveError;
}

Expand All @@ -122,6 +124,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_capp_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_capp_check_quiesce: Entering ....");
// mark HWP entry

fapi2::buffer<uint64_t> l_data(0);
Expand Down Expand Up @@ -207,6 +210,7 @@ extern "C" {
}

fapi_try_exit:
FAPI_IMP("p9_capp_check_quiesce: Exiting ....");
return fapi2::current_err;
}

Expand All @@ -215,6 +219,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_phb_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_phb_check_quiesce: Entering ...");
// mark HWP entry
fapi2::buffer<uint64_t> l_data(0);
//We want to set bit 0 (the Quiesce DMA bit)
Expand Down Expand Up @@ -289,6 +294,7 @@ extern "C" {
FAPI_TRY(p9_suspend_io(i_target, true), "ERROR suspending IO");

fapi_try_exit:
FAPI_IMP("p9_phb_check_quiesce: Exiting ...");
return fapi2::current_err;
}

Expand All @@ -297,6 +303,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_npu_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_npu_check_quiesce: Entering...");
// mark HWP entry

const uint32_t c_fence_status_reg_size = 6;
Expand Down Expand Up @@ -415,6 +422,7 @@ extern "C" {
}

fapi_try_exit:
FAPI_IMP("p9_npu_check_quiesce: Exiting...");
return fapi2::current_err;
}

Expand All @@ -423,6 +431,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_vas_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_vas_check_quiesce: Entering...");
// mark HWP entry

fapi2::buffer<uint64_t> l_vas_north_misc_ctl_data(0);
Expand Down Expand Up @@ -472,6 +481,7 @@ extern "C" {
fapi2::putScom(i_target, PU_VAS_MISCCTL, l_vas_north_misc_ctl_data);

fapi_try_exit:
FAPI_IMP("p9_vas_check_quiesce: Exiting...");
return fapi2::current_err;
}

Expand All @@ -480,6 +490,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_nx_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_nx_check_quiesce: Entering....");
// mark HWP entry

fapi2::buffer<uint64_t> l_dma_status_reg_data(0);
Expand Down Expand Up @@ -671,6 +682,7 @@ extern "C" {
#endif

fapi_try_exit:
FAPI_IMP("p9_nx_check_quiesce: Exiting....");
return fapi2::current_err;
}

Expand All @@ -679,6 +691,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_psihb_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_psihb_check_quiesce: Entering...");
// mark HWP entry

fapi2::buffer<uint64_t> l_psihb_data(0);
Expand Down Expand Up @@ -719,6 +732,7 @@ extern "C" {
fapi2::putScom(i_target, PU_TRUST_CONTROL, l_psihb_data);

fapi_try_exit:
FAPI_IMP("p9_psihb_check_quiesce: Exiting...");
return fapi2::current_err;
}

Expand All @@ -727,6 +741,7 @@ extern "C" {
//---------------------------------------------------------------------------------
fapi2::ReturnCode p9_intp_check_quiesce(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target)
{
FAPI_IMP("p9_intp_check_quiesce: Entering...");
// mark HWP entry

fapi2::buffer<uint64_t> l_data(0);
Expand Down Expand Up @@ -886,6 +901,7 @@ extern "C" {
#endif

fapi_try_exit:
FAPI_IMP("p9_intp_check_quiesce: Exiting...");
return fapi2::current_err;
}

Expand Down
9 changes: 6 additions & 3 deletions src/import/chips/p9/procedures/hwp/perv/p9_sbe_sequence_drtm.C
View file
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER sbe Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2016 */
/* Contributors Listed Below - COPYRIGHT 2016,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -158,14 +158,17 @@ fapi2::ReturnCode p9_sbe_sequence_drtm(const fapi2::Target<fapi2::TARGET_TYPE_PR
FAPI_DBG("Current Chip on the system not quiesced - %#018lx", (uint64_t(1) << (63 - validchip)));
break; //From while loop with PENDING return code
}

else
{
FAPI_IMP("Chip [%#018lx] has LQA set", (uint64_t(1) << (63 - validchip)));
FAPI_IMP("Current System configuration : %#010lx - %#x", (l_sys_config >> 32), (uint32_t)l_sys_config);
}
}

validchip++;

} //End of while (validchip <= 63)


FAPI_INF("p9_sbe_sequence_drtm : Exiting ...");

fapi_try_exit:
Expand Down
4 changes: 2 additions & 2 deletions src/import/chips/p9/procedures/hwp/pm/p9_pm_ocb_indir_access.C
View file
Expand Up @@ -74,7 +74,7 @@ fapi2::ReturnCode p9_pm_ocb_indir_access(
uint32_t& o_ocb_act_length,
uint64_t* io_ocb_buffer)
{
FAPI_IMP("Enter p9_pm_ocb_indir_access...");
FAPI_DBG("Enter p9_pm_ocb_indir_access...");
FAPI_DBG("Channel : %d, Operation : %d, No.of 8B Blocks of Data: %d",
i_ocb_chan, i_ocb_op, i_ocb_req_length);

Expand Down Expand Up @@ -253,7 +253,7 @@ fapi2::ReturnCode p9_pm_ocb_indir_access(
o_ocb_act_length);
}

FAPI_IMP("Exit p9_pm_ocb_indir_access...");
FAPI_DBG("Exit p9_pm_ocb_indir_access...");

fapi_try_exit:
return fapi2::current_err;
Expand Down

0 comments on commit d1f28c8

Please sign in to comment.