Skip to content

Commit

Permalink
xip_image: GPTR/overlays stage 1 support
Browse files Browse the repository at this point in the history
Updated p9_xip_dd_section_support to return "overlays not
supported" if sectionId==.overlays is passed as arg.

Further add a small update to xip_image.C to clear the
ddSupport field in XipSection upon deleting a section.

Change-Id: If64a8a6d7046aa857bd2c3f8ca8c1092565df5ad
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40546
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Reviewed-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40647
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
cmolsen authored and sgupta2m committed Jun 15, 2017
1 parent 58d8705 commit e38e29b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/import/chips/p9/xip/p9_xip_image.C
Expand Up @@ -559,7 +559,6 @@ xipSetSectionSize(void* io_image, const int i_section, const uint32_t i_size)


/// Set the properties of a section
//
XIP_STATIC int
xipSetSectionProps(void* io_image, const int i_section, const uint8_t i_props)
{
Expand Down Expand Up @@ -3265,6 +3264,11 @@ int p9_xip_dd_section_support(const void* i_image,
int rc;
P9XipSection section;

if (i_sectionId == P9_XIP_SECTION_HW_OVERLAYS)
{
return P9_XIP_OVERLAYS_NOT_SUPPORTED;
}

rc = p9_xip_get_section(i_image, i_sectionId, &section);

if (!rc)
Expand Down
3 changes: 3 additions & 0 deletions src/import/chips/p9/xip/p9_xip_image.h
Expand Up @@ -1506,6 +1506,8 @@ p9_xip_decode_toc_dump(void* i_image, void* i_dump,

/// Code bug in the ddLevel handling codes
#define P9_XIP_DDLEVEL_CODE_BUG 22
/// Temporary error code to help prevent image co-req for stage 2 release of RTC174302
#define P9_XIP_OVERLAYS_NOT_SUPPORTED 23

/// Applications can expand this macro to declare an array of string forms of
/// the error codes if desired.
Expand Down Expand Up @@ -1534,6 +1536,7 @@ p9_xip_decode_toc_dump(void* i_image, void* i_dump,
"P9_XIP_NO_DDLEVEL_SUPPORT", \
"P9_XIP_DDLEVEL_NOT_FOUND", \
"P9_XIP_DDLEVEL_CODE_BUG", \
"P9_XIP_OVERLAYS_NOT_SUPPORTED", \
}

/// Applications can use this macro to safely index the array of error
Expand Down

0 comments on commit e38e29b

Please sign in to comment.