Skip to content

Commit

Permalink
FSP/RTC: Remove local fsp_in_reset variable
Browse files Browse the repository at this point in the history
Now that we are using fsp_in_rr() to detect FSP reset/reload, fsp_in_reset
become redundant. Lets remove this local variable.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
Vasant Hegde authored and stewartsmith committed Jun 14, 2017
1 parent f4757fb commit a343696
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions hw/fsp/fsp-rtc.c
Expand Up @@ -88,12 +88,6 @@ static enum {

static bool rtc_tod_cache_dirty = false;

/* TODO We'd probably want to export and use this variable declared in fsp.c,
* instead of each component individually maintaining the state.. may be for
* later optimization
*/
static bool fsp_in_reset = false;

struct opal_tpo_data {
uint64_t tpo_async_token;
uint32_t *year_month_day;
Expand Down Expand Up @@ -526,14 +520,10 @@ static bool fsp_rtc_msg_rr(u32 cmd_sub_mod, struct fsp_msg *msg)

switch (cmd_sub_mod) {
case FSP_RESET_START:
lock(&rtc_lock);
fsp_in_reset = true;
unlock(&rtc_lock);
rc = true;
break;
case FSP_RELOAD_COMPLETE:
lock(&rtc_lock);
fsp_in_reset = false;
if (rtc_tod_cache_dirty) {
rtc_flush_cached_tod();
rtc_tod_cache_dirty = false;
Expand Down

0 comments on commit a343696

Please sign in to comment.