Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Developer Testing Setup #1334

Open
omad opened this issue Oct 31, 2022 · 1 comment
Open

Simplified Developer Testing Setup #1334

omad opened this issue Oct 31, 2022 · 1 comment
Assignees
Labels

Comments

@omad
Copy link
Member

omad commented Oct 31, 2022

Summary

At the moment, it's too hard for developers to run the integration tests for ODC. This presents a significant barrier to entry for new contributors, and is a big waste of time even for experienced ODC developers.

The biggest requirement hurdle is having a PostgreSQL server running locally in the background for the integration tests to connect to.

Proposal

I think a good solution would be to use pytest-docker to create a pytest fixture to start a stop a local PostgreSQL server instance using docker, whenever the integration tests are run.

The downside is added a development dependency on Docker. I think Docker is common enough in 2022 that this will still be a win for new and existing developers.

@omad omad changed the title Simplifier Developer Testing Setup Simplified Developer Testing Setup Dec 7, 2022
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants