[Invoices] Notify if any order cannot be invoiced on bulk invoice sending #12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdellani
force-pushed
the
12374-bulkk-sending-invoice-must-show-error-if-abn-require-and-not-set
branch
5 times, most recently
from
3e86db5
to
3d32f70
Compare
rioug
added
technical changes only
rioug
requested changes
May 20, 2024
app/reflexes/admin/orders_reflex.rb
Outdated
| def distributors_without_abn(orders) | ||
| Enterprise.where( | ||
| id: orders.select(:distributor_id), | ||
| abn: [nil,""], |
There was a problem hiding this comment.
The empty string abnisn't cover by specs, could you update that ?
abdellani
force-pushed
the
12374-bulkk-sending-invoice-must-show-error-if-abn-require-and-not-set
branch
from
7a05c7f
to
9caa9db
Compare
abdellani
force-pushed
the
12374-bulkk-sending-invoice-must-show-error-if-abn-require-and-not-set
branch
from
9caa9db
to
b0862d2
Compare
rioug
approved these changes
Jun 11, 2024
mkllnk
approved these changes
Jun 11, 2024
filipefurtad0
added
pr-staged-fr
|
Hey @abdellani , Tried both described scenarios, after making ABN mandatory for the instance, and deleting the ABN for the enterprise. On the orders page:
Looks great! Merging :-) |
filipefurtad0
merged commit b1f7807
into
openfoodfoundation:master
53 of 54 checks passed
dacook
changed the title
RachL
added
technical changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates