Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when making errors in declarations #20

Open
samsmith opened this issue May 17, 2019 · 2 comments
Open

when making errors in declarations #20

samsmith opened this issue May 17, 2019 · 2 comments

Comments

@samsmith
Copy link
Contributor

On the form submission at /declare/, if the page is shown due to data entry failing validation checks, do not run the "hide the form" javascript at the bottom of the page

if PharmaBenefits.errors or PharmaBenefits.non_form_errors or Declaration.errors or Declaration.non_form_errors

@davidmiller
Copy link
Member

It's trivial enough not to do this if there are form errors in any of those forms.
There's probably a more elegant design than this but for now, sure let's do that.

@davidmiller davidmiller modified the milestone: Sprint July 19 Jul 1, 2019
@davidmiller
Copy link
Member

This form is going to be completely rewritten - leaving open for now to remember not to make the same mistake, but probably not worth fixing for the current form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants