Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I update coastlines / oceans from OSM? #1612

Open
thorsteinssonh opened this issue Jan 10, 2024 · 4 comments
Open

How do I update coastlines / oceans from OSM? #1612

thorsteinssonh opened this issue Jan 10, 2024 · 4 comments

Comments

@thorsteinssonh
Copy link

I have an issue that coast lines are not in sync with OSM, i.e.:
https://www.openstreetmap.org/#map=15/63.7414/-22.9558

but on our map we have an old hole / boundary around this island that was incorrectly drawn before on OSM but fixed a few months ago,
looks like this on our map tile render:
https://ja.is/kort/?x=304815&y=367806&nz=10.49

I read in an older OMT thread that coast-lines are or used to be baked into the OMT project and not fetched on demand from OSM.
If this is the case, is there a way for me to update the water / coast-lines from OSM in my project?

@thorsteinssonh
Copy link
Author

ok hm, I found that this line in my .env file was the problem TOOLS_VERSION=latest probably for some reason resulting in a bad version of the data import image being used. I had to set this to TOOLS_VERSION=7.0 as is on master for my import of ocean coastlines to work properly. Does tools version lates result in some wrong docker image to be fetched, some image not related to officially latest version?

@TomPohys
Copy link
Member

Hi, sorry for the delay. The OSM Ocean is part of import-data docker in OpenMapTiles-Tools. The docker image v7.0 was built in September 2022 (I know, it is old) with the ocean from that date. The latest image is built from master branch for each commit so it was build in June 2023.

If you need the most fresh data, please build import-data docker (in OpenMapTiles-Tools repo -> make build-import-data) on your local and use that version which will contain the latest ocean. You can also change the version of your local docker build by changing the __init__.py. And after that you can change the version of import-data image in OpenMapTiles docker-compose.yml

@thorsteinssonh
Copy link
Author

@TomPohys thanks so much for the assistance. Yes the issue for me was that I was using a fork that at some point had TOOLS_VERSION=latest set as the docker image choice, and ./quickstart.sh --empty iceland should have ran the image without any baked-in ocean data, if I understood correctly the comments in the quickstart script. However, with the latest image this --empty option was probably somehow not working with that image version.
When I changed the version to 7.0 the --empty option worked and I got the recent update of the coast-lines and the problem was solved.

Thank you also for the hint about building the import image locally, that will definitely help me trouble-shoot any further issues.

@thorsteinssonh
Copy link
Author

thorsteinssonh commented Jan 16, 2024

Possibly the issue lies with how I set the TOOLS_VERSION in the .env file. If I set it to version 7.0 then all is fine because possibly has a very old version of coastlines as you suggested, the very old version having pretty OK coastlines, before someone messed it up on OSM. What I should have done is build the openmaptiles-import image as you said, but then tag it to a certain version and then make sure that this version tag is being used in the .env config, therefore avoiding fetching a pre-built image that includes out of date data. Will do some tests to make sure this is the problem in fact. Was confusing to me that 7.0 is OK, while latest is not, but in hindsight it makes perfect sense based on the build times of those docker hub images you mentioned in your answer. So, this is almost certainly the issue, I can build from latest, but then I must make sure the .env file TOOLS_VERSION variable uses that image, else some older build will be fetched :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants