[#691] %MT::addons is now lexically scoped within a closure and can…

…not be accessed/changed directly. Since this was used only by `MT::find_addons()`, no accessor/mutator has been provided.
openmelody · Jan 25, 2011 · 1e41e31 · 1e41e31
1 parent a0f5b1a
commit 1e41e31
Showing 1 changed file with 19 additions and 17 deletions.
diff --git a/lib/MT.pm b/lib/MT.pm
@@ -1698,26 +1698,28 @@ sub _perl_init_plugin_warnings {
     } ## end if ($needs_warning)
 } ## end sub _perl_init_plugin_warnings
 
-my %addons;
+{
+    my %addons;
 
-sub find_addons {
-    my $mt = shift;
-    my ($type) = @_;
-    unless (%addons) {
-        my @PluginPaths;
-        my $cfg = $mt->config;
-        unshift @PluginPaths, File::Spec->catdir( $MT_DIR, 'addons' );
-        unshift @PluginPaths, $cfg->PluginPath;
-        foreach my $PluginPath (@PluginPaths) {
-            __merge_hash( \%addons,
-                          $mt->scan_directory_for_addons($PluginPath) );
+    sub find_addons {
+        my $mt = shift;
+        my ($type) = @_;
+        unless (%addons) {
+            my @PluginPaths;
+            my $cfg = $mt->config;
+            unshift @PluginPaths, File::Spec->catdir( $MT_DIR, 'addons' );
+            unshift @PluginPaths, $cfg->PluginPath;
+            foreach my $PluginPath (@PluginPaths) {
+                __merge_hash( \%addons,
+                              $mt->scan_directory_for_addons($PluginPath) );
+            }
         }
+        if ($type) {
+            my $addons = $addons{$type} ||= [];
+            return $addons;
+        }
+        return 1;
     }
-    if ($type) {
-        my $addons = $addons{$type} ||= [];
-        return $addons;
-    }
-    return 1;
 }
 
 sub scan_directory_for_addons {