Skip to content

Commit

Permalink
[#974] Miscellaneous unit test fixes and pruning of old unit tests re…
Browse files Browse the repository at this point in the history
…sults
  • Loading branch information
jayallen committed Jul 11, 2011
1 parent 861b9a2 commit d94b55a
Show file tree
Hide file tree
Showing 25 changed files with 7,950 additions and 6,601 deletions.
14 changes: 7 additions & 7 deletions addons/MultiBlog.plugin/lib/MultiBlog/Melody.pm
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ MultiBlog plugin.
=head1 METHODS
=over 4 search_blog_filter
=head2 search_blog_filter
This method is invoked via the search_blog_list callback. It is responsible
for modifying the list of blogs to be included and excluded from a search.
Expand All @@ -62,26 +62,26 @@ intent of the setting.
Users should be warned that Six Apart advises the following with regards to
this capability:
1) The prospective behavior (having search.cgi respect Multiblog privacy
=over 4
=item 1. The prospective behavior (having search.cgi respect Multiblog privacy
settings) was never an intended function of the Multiblog plugin.
2) Movable Type already provides the IncludeBlogs and ExcludeBlogs
=item 2. Movable Type already provides the IncludeBlogs and ExcludeBlogs
configuration directives to specify blogs to be included or excluded in a
search.
3) Multiblog plugin privacy settings shouldn't interact with or override the
=item 3. Multiblog plugin privacy settings shouldn't interact with or override the
IncludeBlogs / ExcludeBlogs configuration directives. That could lead to
unexpected results, particularly if the settings conflict with each other.
4) Altering the functionality as proposed would make troubleshooting issues
=item 4. Altering the functionality as proposed would make troubleshooting issues
with the inclusion / exclusion of blogs in searches much more difficult.
There would be no clear way for Movable Type to show that Multiblog
privacy settings influence the search results, or that Multiblog privacy
settings may be overriding explicit IncludeBlogs / ExcludeBlogs settings
in the config.cgi configuration file.
=item
=back
=head1 AUTHOR & COPYRIGHTS
Expand Down
19 changes: 9 additions & 10 deletions addons/ThemeExport.plugin/lib/MT/Theme/Exporter.pm
Original file line number Diff line number Diff line change
Expand Up @@ -660,16 +660,14 @@ B<Options:>
=over 4
id key pack_name pack_description pack_version dryrun verbose
logger app author_name author_link basedir zip
=item C<id>
The ID of the plugin created.
=item C<key>
The MT::PluginData key for the plugin. This will also be used for the plugin's plugin envelope name.
The MT::PluginData key for the plugin. This will also be used for the plugin's
plugin envelope name.
=item C<pack_name>
Expand All @@ -685,8 +683,8 @@ The version number of the plugin generated.
=item C<dryrun>
If set to 1 (true) then the export operation will not actually do anything, but will instead
simply log what it would have done.
If set to 1 (true) then the export operation will not actually do anything,
but will instead simply log what it would have done.
=item C<verbose>
Expand Down Expand Up @@ -718,9 +716,10 @@ The target directory of the plugin generated.
=item C<basedir>
The directory name into which all plugin files will be placed. The absolute path of where the theme will
be exported can be found by appending C<outdir> and C<basedir>. The default value of C<basedir> is the
key plus the version number.
The directory name into which all plugin files will be placed. The absolute
path of where the theme will be exported can be found by appending C<outdir>
and C<basedir>. The default value of C<basedir> is the key plus the version
number.
=item C<zip>
Expand All @@ -740,7 +739,7 @@ This method will do nothing if the "dryrun" option has been selected.
=head1 VERSION CONTROL
L<http://github.com/byrnereese/mt-tool-exportts
L<http://github.com/byrnereese/mt-tool-exportts>
=head1 AUTHORS and CREDITS
Expand Down
2 changes: 1 addition & 1 deletion addons/ThemeExport.plugin/lib/MT/Theme/Util.pm
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ It requires that you have been given an API Key by PicApp.
=head1 VERSION CONTROL
L<http://github.com/byrnereese/mt-plugin-theme-export
L<http://github.com/byrnereese/mt-plugin-theme-export>
=head1 AUTHORS and CREDITS
Expand Down
2 changes: 2 additions & 0 deletions lib/MT/App.pm
Original file line number Diff line number Diff line change
Expand Up @@ -4223,6 +4223,8 @@ C<MT::Image::has_html_signature>) for HTML-ish content within the first 1K of
the data. Image files (in particular) that contain embedded HTML or JavaScript
are a known vector for an IE 6 and 7 content-sniffing vulnerability.
=back
=head2 $app->uri_params(%param)
A utility method that assembles the query portion of a URI, taking
Expand Down
15 changes: 7 additions & 8 deletions lib/MT/Callback.pod
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,11 @@ MT callbacks are typically in one of these forms:

=item * callback_name

This is the most common form of callback name and is generally recommended for new
callbacks in order to provide consistency. Examples of these include most of the
L<MT::Object> callbacks (such as C<pre_save>, C<post_save>, etc.) and the
L<MT::WeblogPublisher> callbacks (e.g. build_file_filter, build_page, build_file).
This is the most common form of callback name and is generally recommended for
new callbacks in order to provide consistency. Examples of these include most
of the L<MT::Object> callbacks (such as C<pre_save>, C<post_save>, etc.) and
the L<MT::WeblogPublisher> callbacks (e.g. build_file_filter, build_page,
build_file).

=item * CallbackName

Expand Down Expand Up @@ -760,8 +761,6 @@ The C<$feed> parameter is a scalar reference to a string-- the contents
of the generated feed. Upon return, this value is printed out. The content
should be an Atom-based feed.

=back

=head1 API Callbacks

=head2 Publishing
Expand Down Expand Up @@ -849,8 +848,8 @@ false if a page was actually created on disk for this "page," and false if no
page was created (because the corresponding template is set to be
built dynamically).

It is possible for the C<FileInfo> parameter to be undefined, namely if the blog
has not been configured to publish anything dynamically, or if the
It is possible for the C<FileInfo> parameter to be undefined, namely if the
blog has not been configured to publish anything dynamically, or if the
installation is using a data driver that does not support dynamic publishing.

=back
Expand Down
52 changes: 30 additions & 22 deletions lib/MT/Revisable.pm
Original file line number Diff line number Diff line change
Expand Up @@ -404,15 +404,15 @@ Checks whether the passed column name has been marked as being revisioned
=head2 $obj->gather_changed_cols($orig, $app)
Compares the revisioned columns of C<$orig> with C<$obj> and stores an arrayref
of changed columns in C<$obj->{changed_revisioned_columns}>
Compares the revisioned columns of C<$orig> with C<$obj> and stores an
arrayref of changed columns in C<$obj->{changed_revisioned_columns}>
=head2 $obj->pack_revision()
Creates the hashref that will be stored as a particular revision of the object.
By default, this hashref contains the values of the object's normal and meta
columns. The C<<package>::pack_revision> callback can be used to add further
values to be stored with the revision.
Creates the hashref that will be stored as a particular revision of the
object. By default, this hashref contains the values of the object's normal
and meta columns. The C<<package>::pack_revision> callback can be used to add
further values to be stored with the revision.
=head2 $obj->unpack_revision($packed_obj)
Expand All @@ -431,9 +431,10 @@ Saves a revision only if at least one revisioned column has changed.
=head2 $obj->load_revision(\%terms, \%args)
Loads revisions for the C<$obj>. Arguments work similarly to C<MT::Object->load>.
Thus, one can simply do C<$obj->load_revision($rev_numer)> or pass terms and
args. Terms can be any of the following:
Loads revisions for the C<$obj>. Arguments work similarly to
C<MT::Object->load>. Thus, one can simply do
C<$obj->load_revision($rev_numer)> or pass terms and args. Terms can be any of
the following:
=over
Expand Down Expand Up @@ -463,13 +464,13 @@ C<load_revision> should return an/array of arrayref(s) of:
=head2 $obj->apply_revision(\%terms, \%args)
Rolls back to the state of the object at C<$obj->load_revision(\%terms, \%args)>
and saves this action as a revision.
Rolls back to the state of the object at C<$obj->load_revision(\%terms,
\%args)> and saves this action as a revision.
=head2 $obj->diff_object($obj_b)
Returns a hashref of column names with the values being an arrayref representation
of the diff:
Returns a hashref of column names with the values being an arrayref
representation of the diff:
[<flag>, <left>, <right>]
Expand All @@ -495,11 +496,11 @@ information.
my ($cb, $obj, $values) = @_;
}
This callback is run after C<$values> is initially populated by C<$obj->pack-revision()>
and is a hashref of the normal and meta column values and allows you to modify
C<$values> before it is saved with the revision. Thus, you can use this callback
to augment what is stored with every revision.
This callback is run after C<$values> is initially populated by
C<$obj->pack-revision()> and is a hashref of the normal and meta column values
and allows you to modify C<$values> before it is saved with the revision.
Thus, you can use this callback to augment what is stored with every revision.
=head2 <package>::unpack_revision
Expand Down Expand Up @@ -553,12 +554,16 @@ detected by the default handler.
=head1 DRIVERS
The majority of the methods MT::Revisable provides are implemented by driver
modules. These driver modules specify how versions of an object are saved and
retrieved from a data store. By default, MT::Revisable uses the
MT::Revisable::Local driver which saves versions within the Movable Type database.
modules. These driver modules specify how versions of an object are saved and
retrieved from a data store. By default, MT::Revisable uses the
MT::Revisable::Local driver which saves versions within the Movable Type
database.
To change this, you would first need to create a driver that implements the
following methods:
=over 4
=item * revision_pkg
=item * revision_props
Expand All @@ -569,7 +574,10 @@ following methods:
=item * load_revision
If some of the above methods are not applicable to your driver, simply return undef.
=back
If some of the above methods are not applicable to your driver, simply return
undef.
=head1 QUESTIONS TO INVESTIGATE/DOCUMENT
Expand Down
8 changes: 4 additions & 4 deletions lib/MT/Template/ContextHandlers.pm
Original file line number Diff line number Diff line change
Expand Up @@ -22181,15 +22181,15 @@ sub _hdlr_widget_set_name {

###########################################################################

=head2 WidgetSetId

Used within a WidgetSetLoop context. This returns the ID number of the widget set.
=head2 WidgetSetID

Used within a WidgetSetLoop context. This returns the ID number of the widget
set.

=for tags widgets

=cut


sub _hdlr_widget_set_id {
my ( $ctx, $args ) = @_;
my $ws = $ctx->stash('widgetset')
Expand Down
Loading

0 comments on commit d94b55a

Please sign in to comment.