Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi groups #129

Merged
merged 16 commits into from Mar 28, 2012
Merged

Multi groups #129

merged 16 commits into from Mar 28, 2012

Conversation

jburel
Copy link
Member

@jburel jburel commented Mar 21, 2012

Following discussion about multi-groups support, I have added the option to add several users/groups at a time
Follow the list of tickets covered by this PR.

https://trac.openmicroscopy.org.uk/ome/ticket/8106
https://trac.openmicroscopy.org.uk/ome/ticket/8107
https://trac.openmicroscopy.org.uk/ome/ticket/8149
https://trac.openmicroscopy.org.uk/ome/ticket/8276
https://trac.openmicroscopy.org.uk/ome/ticket/8321
https://trac.openmicroscopy.org.uk/ome/ticket/8345

Review the way the users and the groups are selected and added.

@jburel
Copy link
Member Author

jburel commented Mar 21, 2012

@jburel
Copy link
Member Author

jburel commented Mar 22, 2012

@omeroscott: groups work to be tested with http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/107/

@omeroscott
Copy link

Tested using merge blue 107

I am still not able to switch groups and add groups. You were not previously able to see the list of groups you were a member of, so logged in as scott on gretzky I can now see the 5 groups I am a member of but it will not let me add to my default group of Swedlow or switch from this group.

@jburel
Copy link
Member Author

jburel commented Mar 23, 2012

@omeroscott to be tested with http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/108/..
I removed the correct lines during the merge.

@omeroscott
Copy link

Tested on merge blue 108

Working as expected.

@jburel
Copy link
Member Author

jburel commented Mar 23, 2012

From @omeroscott: Group selection, do not close dialog when no group selected.
J-M: I will add controls so the apply button is enabled when at least one group is selected.

Conflicts:
	components/insight/SRC/org/openmicroscopy/shoola/agents/treeviewer/view/ToolBar.java
	components/insight/SRC/org/openmicroscopy/shoola/agents/treeviewer/view/TreeViewer.java
@jburel
Copy link
Member Author

jburel commented Mar 23, 2012

@omeroscott: review the group selection. To test using http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/109/

@omeroscott
Copy link

Tested using merge blue 109

@jburel re-tested add group controls so the apply button is disable when no group is selected and when at least one group is selected.

@joshmoore
Copy link
Member

I don't understand the "Add user to" option. Perhaps my confusion was caused by looking at groups that only had one member, so I tried to add more, at which point I noticed that the "Add experimenters" dialog looks to be unsorted.

@joshmoore
Copy link
Member

Also, I don't know if it's related to this PR, but insight just hung and I had to "force quit" it. Nothing much in the stack trace other than:

"Initializer" prio=5 tid=105970800 nid=0x10edbd000 in Object.wait() [10edbc000]
   java.lang.Thread.State: WAITING (on object monitor)
        at java.lang.Object.wait(Native Method)
        - waiting on <7dbb29578> (a org.openmicroscopy.shoola.env.ui.SplashScreenFuture)
        at java.lang.Object.wait(Object.java:485)
        at org.openmicroscopy.shoola.env.ui.SplashScreenFuture.get(SplashScreenFuture.java:88)
        - locked <7dbb29578> (a org.openmicroscopy.shoola.env.ui.SplashScreenFuture)
        at org.openmicroscopy.shoola.env.ui.SplashScreenProxy.getUserCredentials(SplashScreenProxy.java:223)
        at org.openmicroscopy.shoola.env.init.SplashScreenInit.onEnd(SplashScreenInit.java:166)
        at org.openmicroscopy.shoola.env.init.Initializer.notifyEnd(Initializer.java:190)
        at org.openmicroscopy.shoola.env.init.Initializer.doInit(Initializer.java:260)
        at org.openmicroscopy.shoola.env.Container.runStartupProcedure(Container.java:115)
        at org.openmicroscopy.shoola.env.Container.access$000(Container.java:71)
        at org.openmicroscopy.shoola.env.Container$1.run(Container.java:159)
        at java.lang.Thread.run(Thread.java:680)

@joshmoore
Copy link
Member

Sorry, the hung app was clicking "cancel" during login. That's probably in a separate ticket, no?

@jburel
Copy link
Member Author

jburel commented Mar 26, 2012

@joshmoore:

@jburel
Copy link
Member Author

jburel commented Mar 26, 2012

@joshmoore: for the wording of the options, I will discuss that with Will when he is ready. This will happen outside the scope of that PR.

@jburel
Copy link
Member Author

jburel commented Mar 26, 2012

@joshmoore, @omeroscott: to be tested using http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/111/

https://trac.openmicroscopy.org.uk/ome/ticket/8383

  • User is a member of one group only and the group has several users.

@omeroscott
Copy link

@jburel A separate issue that was seen during testing.

  • Log in as scott
  • Chose to add Gus from within the Swedlow group
  • Expand the tree of Gus
  • A message of connection refused 'the server is no longer running please contact your system administrator. The application will now exit.'

@jburel
Copy link
Member Author

jburel commented Mar 27, 2012

@joshmoore, @omeroscott:
The problem you reported is related to
`Comment (by wmoore):
I have now set the session.timout on gretzky to 30 seconds. Testing so far

seems to be behaving as expected.

Ticket URL: http://trac.openmicroscopy.org.uk/ome/ticket/8386#comment:2
`
Modifying this kind of stuff could/will have unexpected impact.

@omeroscott
Copy link

Tested @jburel @joshmoore using build merge blue #112

working as expected

  • #8383 User member of one group only

@joshmoore
Copy link
Member

Tested by Scott. Merging

joshmoore added a commit that referenced this pull request Mar 28, 2012
@joshmoore joshmoore merged commit 8116e52 into ome:develop Mar 28, 2012
mtbc added a commit to mtbc/openmicroscopy that referenced this pull request May 21, 2020
Rename tests for 2019-SV6 to better capture the difference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants