New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi groups #129
Multi groups #129
Conversation
PR to be tested using http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/104/ |
@omeroscott: groups work to be tested with http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/107/ |
Tested using merge blue 107 I am still not able to switch groups and add groups. You were not previously able to see the list of groups you were a member of, so logged in as scott on gretzky I can now see the 5 groups I am a member of but it will not let me add to my default group of Swedlow or switch from this group. |
@omeroscott to be tested with http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/108/.. |
Tested on merge blue 108 Working as expected. |
From @omeroscott: Group selection, do not close dialog when no group selected. |
Conflicts: components/insight/SRC/org/openmicroscopy/shoola/agents/treeviewer/view/ToolBar.java components/insight/SRC/org/openmicroscopy/shoola/agents/treeviewer/view/TreeViewer.java
@omeroscott: review the group selection. To test using http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/109/ |
Tested using merge blue 109 @jburel re-tested add group controls so the apply button is disable when no group is selected and when at least one group is selected. |
I don't understand the "Add user to" option. Perhaps my confusion was caused by looking at groups that only had one member, so I tried to add more, at which point I noticed that the "Add experimenters" dialog looks to be unsorted. |
Also, I don't know if it's related to this PR, but insight just hung and I had to "force quit" it. Nothing much in the stack trace other than:
|
Sorry, the hung app was clicking "cancel" during login. That's probably in a separate ticket, no? |
|
@joshmoore: for the wording of the options, I will discuss that with Will when he is ready. This will happen outside the scope of that PR. |
Review the addition when the user is member of only one group.
@joshmoore, @omeroscott: to be tested using http://hudson.openmicroscopy.org.uk/job/OMERO-merge-blue/111/ https://trac.openmicroscopy.org.uk/ome/ticket/8383
|
@jburel A separate issue that was seen during testing.
|
@joshmoore, @omeroscott: seems to be behaving as expected.Ticket URL: http://trac.openmicroscopy.org.uk/ome/ticket/8386#comment:2
|
Tested @jburel @joshmoore using build merge blue #112 working as expected
|
Tested by Scott. Merging |
Rename tests for 2019-SV6 to better capture the difference.
Following discussion about multi-groups support, I have added the option to add several users/groups at a time
Follow the list of tickets covered by this PR.
https://trac.openmicroscopy.org.uk/ome/ticket/8106
https://trac.openmicroscopy.org.uk/ome/ticket/8107
https://trac.openmicroscopy.org.uk/ome/ticket/8149
https://trac.openmicroscopy.org.uk/ome/ticket/8276
https://trac.openmicroscopy.org.uk/ome/ticket/8321
https://trac.openmicroscopy.org.uk/ome/ticket/8345
Review the way the users and the groups are selected and added.