Handle all Ironic states

[stbenjam]

We should handle all Ironic states, including all the possible failed states.

e.g. clean wait wasn't handled. That was fixed here - #16, need to handle the rest.

See: https://docs.openstack.org/ironic/pike/_images/states.svg

[dtantsur]

Also some handling is concerning. E.g. if enroll -> manageable transition fails, we go back to enroll. In this case the existing code will loop forever.

Similarly, the cleaning and deploying handling code does not account for errors, trying to redeploy/reclean instead (it won't work).

[dtantsur]

And a small correction: https://docs.openstack.org/ironic/stein/_images/states.svg is more up-to-date (pike is old, nearly out of support).

[stbenjam]

Also some handling is concerning. E.g. if enroll -> manageable transition fails, we go back to enroll. In this case the existing code will loop forever.

How does one detect failure? Is last_error non-blank - is that the only way? It's odd this one doesn't have a failed state.

[dtantsur]

Yeah, this one is a bit weird. However, enroll + last_error should give you enough information. A node in enroll cannot get a non-empty last_error any other way.

[dhellmann]

Is this still an issue?

[stbenjam]

Yes. Enroll -> manageable failure isn’t handled yet at least.