Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad antenna after flight or telemetry reset #2015

Closed
janekx opened this issue Jan 16, 2015 · 3 comments
Closed

Bad antenna after flight or telemetry reset #2015

janekx opened this issue Jan 16, 2015 · 3 comments

Comments

@janekx
Copy link

janekx commented Jan 16, 2015

Did found bad bug in reset of the Flight and Telemetry.
Taranis Plus B01
When reset flight or telemetry, the SWR value goes from 0 to 255 and back to 0, in this time OpenTX alert bad antenna.
This should not happend.

@projectkk2glider
Copy link
Member

Confirmed from the sources:

  • when telemetry is reset all values go to zero (including SWR)
  • until XJT_VERSION_ID is recieved the IS_VALID_XJT_VERSION() is false
  • if SWR packet comes and IS_VALID_XJT_VERSION() is still false, the SWR gets set to 0xFF.

@bsongis
Copy link
Member

bsongis commented Jan 28, 2015

Confirmed. I can't remind why we set SWR to 0xFF when IS_VALID_XJT_VERSION() is false. Right now I would set it to 0x00

bsongis added a commit that referenced this issue Jan 28, 2015
@bsongis
Copy link
Member

bsongis commented Jan 28, 2015

I will mark this one as fixed once the whole SWR masking feature is ported to 'next'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants