Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tf.Graph decoder accuracy fixes #19903

Merged
merged 10 commits into from Sep 19, 2023
Merged

tf.Graph decoder accuracy fixes #19903

merged 10 commits into from Sep 19, 2023

Conversation

popovaan
Copy link
Contributor

@popovaan popovaan commented Sep 18, 2023 •
edited

Description:

  • Fixed output names passed from tf.Graph decoder.
  • Fixed order of internal names in output_names_map.
  • Added support of variables of non-resource type.
  • Removed usage of _name attribute for comparison of EagerTensor's.

Ticket: 119718

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names
  • Transformation preserves tensor names

Validation:

  • Unit tests
  • Framework operation tests
  • Transformation tests
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list
  • Guide on how to convert the public model
  • User guide update

@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: TF FE OpenVINO TensorFlow FrontEnd labels Sep 18, 2023
@popovaan popovaan marked this pull request as ready for review September 18, 2023 16:16
@popovaan popovaan requested review from a team as code owners September 18, 2023 16:16
@popovaan popovaan requested review from a team as code owners September 19, 2023 08:27
rkazants
rkazants approved these changes Sep 19, 2023
View reviewed changes
src/bindings/python/src/openvino/frontend/tensorflow/utils.py Show resolved Hide resolved
src/frontends/tensorflow/src/translate_session.cpp
ind++;
break;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this change. How is it different from the current version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor this code a bit in the next PR as discussed offline

@rkazants rkazants enabled auto-merge (squash) September 19, 2023 12:55
@rkazants rkazants merged commit 215a2f4 into openvinotoolkit:master Sep 19, 2023
58 checks passed
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@popovaan @alvoron
tf.Graph decoder accuracy fixes (openvinotoolkit#19903)
b653cc7 
* Fixed outputs passing from decoder.

* Fixed get_variable method.

* Code style.

* Removed xfails from precommit models.

* Minor fix.

* Comment fixed.

* Added test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

Assignees
No one assigned
Labels
category: Python API OpenVINO Python bindings category: TF FE OpenVINO TensorFlow FrontEnd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@popovaan @rkazants