Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Modulo-zero in SoftwareUpdateManager #433

Open
jaylogue opened this issue Nov 26, 2019 · 1 comment
Open

Modulo-zero in SoftwareUpdateManager #433

jaylogue opened this issue Nov 26, 2019 · 1 comment

Comments

@jaylogue
Copy link
Contributor

The code in GenericSoftwareUpdateManagerImpl<>::ComputeNextScheduledWaitTimeInterval() will generate a modulo-zero condition (i.e. x%0) if the query interval minimum and maximum wait times are set to the same value.

Similarly, code in GenericSoftwareUpdateManagerImpl<>::DefaultRetryPolicyCallback() will generate a modulo-zero if maxWaitTimeInMsec and minWaitTimeInMsec evaluate to the same value, e.g. due to integer rounding.

@jaylogue
Copy link
Contributor Author

@suryanshup Do you know if this has been addressed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant