Chef 1715

[jesseproudman]

We've completed the code for the initial integration of Blue Box Blocks with knife. We've confirmed deployments, destructions, and associated commands work. Please review and provide any feedback.

Thanks

• Jesse Proudman
• Blue Box Group

[danielsdeleo]

Hi there, a few comments.

1. On some of the files, the copyright is assigned to Jim Van Fleet, but I don't see him listed in our approved contributors list (http://wiki.opscode.com/display/chef/Approved+Contributors).
2. Can you move the bootstrapping scripts to a template, or use one of the existing ones, and run a bootstrap command against the server instance instead of in-lining it?
3. Can you convert tab characters to 2 spaces.

Thanks,
Dan DeLeo

[jesseproudman]

Hi Dan,

1. We've gotten Jim to submit the appropriate paperwork and I see he's now listed as a contributer.
2. I believe we're already using your bootstrapping scripts, no? See: http://github.com/blueboxjesse/chef/blob/CHEF-1715/chef/lib/chef/knife/bluebox_server_create.rb
3. Ian went through and converted all tabs to 2 spaces. It looks like this affected a significant number of files, so I'm not sure how you'd like us to handle this.

Thanks!

• Jesse

[jesseproudman]

Hi Dan,

I think I see where you were confused on the bootstrap component. We've removed those redundant files.

[jesseproudman]

Any update here? We'd love to see this included by RubyConf.

[danielsdeleo]

Merged in 11ef5a9, thanks guys. Have a good rubyconf ;)