Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph on hover ID buttons to left not showing up on live editor/absolute positioning generating a toplevel scrollbar on header hover #13

Closed
cirosantilli opened this issue Mar 30, 2020 · 0 comments
Labels
Milestone

Comments

@cirosantilli
Copy link
Contributor

cirosantilli commented Mar 30, 2020

Almost fully working prototype at: https://github.com/cirosantilli/cirodown/tree/flex-hoverlinks

https://cirosantilli.com/cirodown/editor

cirodown cedbac7

Also image is too indented right.

Edit: if we remove the it starts showing (rendered output has to be direct child of class=cirodown element, but it shows to the left of the editor.

position: absolute from cirodown.css is not playing well with the parent flex set in the editor output.

Related:

Maybe we should just get rid of position: absolute, and instead make the link span take up space, and remove left margin.

When doing this, also make the entire height of the margin into a link to the current element. Maybe hightlight that instead of the element itself when currently selected #.

@cirosantilli cirosantilli added this to the 2 milestone Apr 27, 2020
cirosantilli added a commit that referenced this issue Apr 28, 2020
There is one remaining problem: vertical margins don't collapse across
toplevel elements so e.g. if we have a list at the end of a paragraph,
then the next paragraph gets a lot of vertical separation from the previous
one. This would solve it but no one found out how:
https://stackoverflow.com/questions/12477272/select-recursive-last-child-possible

Fix #13
@cirosantilli cirosantilli changed the title Paragraph on hover ID buttons to left not showing up on live editor Paragraph on hover ID buttons to left not showing up on live editor/absolute positioning generating a toplevel scrollbar on header hover Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant