disable cache for all tests except test_cache.py and benchmark tests
#886
Conversation
lapp0
changed the title
test_cache.py tests
lapp0
changed the title
test_cache.py teststest_cache.py and benchmark tests
| @@ -7,7 +7,10 @@ | |||
| import cloudpickle | |||
| from diskcache import Cache | |||
|
|
|||
| _caching_enabled = True | |||
| if os.environ.get("OUTLINES_DISABLE_CACHE", "") in ("", "0"): | |||
There was a problem hiding this comment.
Why do we need an environment variable for this?
Also, can't we use the existing disable_cache function?
There was a problem hiding this comment.
It may be beneficial to introduce an environment variable that allows users disable cache, even outside of pytest.
I could also simply make the disable_cache fixure patch this variable and have no changes to caching.py if we don't want to expose this.
|
We need a general solution that is applied to all test cases in I agree about the environment variable being a problem. The cleanest solution is to clear the cache before each individual test run. This won't require any special handling for benchmarks or |
Clearing the cache is another necessarily "global" approach with similar drawbacks. Ideally, we would have something that works, still allows the tests to be run in parallel, and introduces a minimal amount of new code/logic (even if said code can be multi-purposed). |
|
Thanks for reviewing. Indeed, we want to ensure the code remains robust. I'll close this for now. |
Fixes #853