Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit txt-previews #11

Closed
nickvergessen opened this issue May 14, 2014 · 1 comment
Closed

Revisit txt-previews #11

nickvergessen opened this issue May 14, 2014 · 1 comment
Labels

Comments

@nickvergessen
Copy link
Contributor

.txt previews are generated with a white background, which is now displayed on white background instead of gray background compared to before
owncloud-archive/apps#1769 (comment)

Might not be an issue for normal files as they are not as empty as the one-line testing files I used

@jancborchardt
Copy link
Member

Normally I would suggest adding a slight border around the preview, but that would make the filetype icons look bad. And honestly, this is only an issue occuring with one-line or completely empty text files.

I’ll close this hence. We can discuss it again if it comes up in production use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants