Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on settings in sharing dialogue #2889

Closed
plages opened this issue Feb 25, 2015 · 7 comments
Closed

Feedback on settings in sharing dialogue #2889

plages opened this issue Feb 25, 2015 · 7 comments
Assignees

Comments

@plages
Copy link

plages commented Feb 25, 2015

I noticed that the desktop sharing takes over the default expiration time from the server. Which makes perfect sense to me. Does anyone agree therew should be feedback about this the first time i create a share? When i click 'Share with ownCloud'the second time on a share, the expiration date and the 'Set expiration data'checkbox are automatically populated. Maybe upon initial creation of the share someting like 'Default expiration time of %serversetting% applies' should appear in the dialogue.
Or else the dialogue should display the same behaviour as when clicked for the second, third etc. time.
Also when expiration and password are mandatory on the server the checkboxes should be enabled by default in the sharing dialogue.

@dragotin dragotin added this to the 1.8.1 - Bugfix milestone Feb 25, 2015
@rullzer
Copy link
Contributor

rullzer commented Feb 26, 2015

I am working on the mandatory password and expiration date. However this requires changes in the server as well. But it is coming.

@dragotin
Copy link
Contributor

Hmm, I reworked the dialog for the final again, so some of the mentioned issues should have gone already.

@plages
Copy link
Author

plages commented Mar 18, 2015

The default expiration time is set on a share when created but this is not reflected in the interface until the user clicks "share with ownCloud" the second time. But maybe this is due to the fact that i'm still on 7.0.4 on the server side.

@rullzer
Copy link
Contributor

rullzer commented Mar 19, 2015

A fix for not displaying the expiration date is in PR #2989. This forces retrieval of the shares on share creation. Since we get much more info that way.

@plages
Copy link
Author

plages commented Mar 19, 2015

Great that'll solve the issue. Is this also possible for the password checkbox in case the server has the password set to mandatory?

@rullzer
Copy link
Contributor

rullzer commented Mar 19, 2015

That should already happen.

ckamm pushed a commit that referenced this issue Mar 26, 2015
This makes sure that if a default expiration date is set this is reflected in
the dialog. #2889
@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Mar 26, 2015
@Dianafg76
Copy link

Cheked for the password checkbox in case the server has the password set to mandatory

@Dianafg76 Dianafg76 added approved by qa and removed ReadyToTest QA, please validate the fix/enhancement labels Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants