Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle permanent redirects #3082

Closed
dragotin opened this issue Apr 8, 2015 · 4 comments
Closed

Handle permanent redirects #3082

dragotin opened this issue Apr 8, 2015 · 4 comments
Assignees
@ckamm
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone
1.8.1 - Bugfix

Comments

@dragotin
Copy link
Contributor

dragotin commented Apr 8, 2015

On the call to status.php, there can happen a permanent redirect reply. The client needs to pick the url coming with that up, store it in the config and use it.

This should be a branding option, see also owncloud/enterprise#499
@dragotin dragotin added the p2-high Escalation, on top of current planning, release blocker label Apr 8, 2015
@dragotin dragotin added this to the 1.8.1 - Bugfix milestone Apr 8, 2015
@ckamm
Copy link
Contributor

ckamm commented Apr 9, 2015

I've tested this and looked at the code. It's already fully implemented.

AbstractNetworkJob has the followRedirects options which is enabled for CheckServerJob. Its instanceFound signal is then emitted with the redirected URL and that is what gets stored in the config file.

@ckamm ckamm closed this as completed Apr 9, 2015
@dragotin
Copy link
Contributor Author

dragotin commented Apr 9, 2015

The current implementation only works with redirects that return from the call to status.php. That is not sufficient, it needs to pick the redirect url up on the first authenticated call to the server.

@dragotin dragotin reopened this Apr 9, 2015
ckamm added a commit to ckamm/owncloud-client that referenced this issue Apr 9, 2015
@ckamm
Handle redirect of auth request. owncloud#3082
8a6c87f
ckamm added a commit that referenced this issue Apr 10, 2015
@ckamm
Handle redirect of auth request. #3082
d9ea693
@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Apr 10, 2015
@ckamm
Copy link
Contributor

ckamm commented Apr 10, 2015

Works for me now!

ckamm added a commit that referenced this issue Apr 10, 2015
@ckamm
AuthRedirect: Use the configured DAV path. #3082
57ac1d9
@Dianafg76
Copy link

I have tested this on a mac and windows clients, a full regression test and everything is working just fine.

@Dianafg76 Dianafg76 added 3 - Done and removed 2 - Testing ReadyToTest QA, please validate the fix/enhancement labels May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
1.8.1 - Bugfix
Development

No branches or pull requests
3 participants
@ckamm @dragotin @Dianafg76