Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid credentials in account setup wizard lead to incorrect error message #3155

Closed
ckamm opened this issue Apr 24, 2015 · 2 comments
Closed

Invalid credentials in account setup wizard lead to incorrect error message #3155

ckamm opened this issue Apr 24, 2015 · 2 comments
Assignees
@ckamm
Labels
bug ReadyToTest QA, please validate the fix/enhancement
Milestone
1.8.1 - Bugfix

Comments

@ckamm
Copy link
Contributor

ckamm commented Apr 24, 2015

When using an incorrect password during account setup the error message "There was an invalid response to an authenticated webdav request" is shown instead of the correct "Access forbidden by...".

This regression is due to the new redirection handling. I added a new finishedWithError() slot and didn't realize networkError() may already have been emitted beforehand.
@ckamm ckamm added the bug label Apr 24, 2015
@ckamm ckamm self-assigned this Apr 24, 2015
@ckamm ckamm added this to the 1.8.1 - Bugfix milestone Apr 24, 2015
ckamm added a commit to ckamm/owncloud-client that referenced this issue Apr 24, 2015
@ckamm
AccountWizard: Fix auth error handling. owncloud#3155
6376d6a 
The problem was that on network error the networkError() and
finishedWithError() signals both fired. To fix it, I collapse all
error handing into a slot triggered by finishedWithError().

I tested the redirection case and the invalid credentials case.
ckamm added a commit that referenced this issue Apr 24, 2015
@ckamm @ogoffart
AccountWizard: Fix auth error handling. #3155
78e82eb 
The problem was that on network error the networkError() and
finishedWithError() signals both fired. To fix it, I collapse all
error handing into a slot triggered by finishedWithError().

I tested the redirection case and the invalid credentials case.
@guruz
Copy link
Contributor

guruz commented Apr 24, 2015

(Found as part of #3135 )

@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Apr 29, 2015
@guruz
Copy link
Contributor

guruz commented Apr 29, 2015

Thanks, it works

@guruz guruz closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
bug ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Milestone
1.8.1 - Bugfix
Development

No branches or pull requests
2 participants
@ckamm @guruz