Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When upgrading of Windows client 2.0 to 2.0.1 sync folders were lost #3747

Closed
tangix opened this issue Sep 4, 2015 · 46 comments
Closed

When upgrading of Windows client 2.0 to 2.0.1 sync folders were lost #3747

tangix opened this issue Sep 4, 2015 · 46 comments
Assignees
Labels
bug p2-high Escalation, on top of current planning, release blocker sev1-critical
Milestone

Comments

@tangix
Copy link

tangix commented Sep 4, 2015

Was prompted this morning to update my Windows Desktop Sync Client to 2.0.1 (build 5445) running on Windows 8.1 64-bit. After the update was installed all configured folders were lost and had to be re-added manually.

@RalfWW
Copy link

RalfWW commented Sep 4, 2015

Same on my side with WIN 7 Prof SP1 German 64bit.

@phil-davis
Copy link
Contributor

My Windows 10 Pro 32 bit English (US) upgraded fine. I have 4 accounts and a total of 7 folder syncs.

@tangix
Copy link
Author

tangix commented Sep 4, 2015

Should probably add that I am running Swedish Windows 8.1. Folder-names issue?

@guruz
Copy link
Contributor

guruz commented Sep 4, 2015

@tangix Did your sync folder name (or any parent folder) contain ø å etc?
@RalfWW or similar?

Were the configured folders gone or the configured folders and the account (URL etc) ?

@tangix
Copy link
Author

tangix commented Sep 4, 2015

@guruz Yes, in Swedish the path is "C:\Användare\msa.TANGIX\owncloud" (C:\Users\msa.TANGIX\ownCloud in Englisg when copying pasting).
And only the synced folder was gone, account info still intact.

@RalfWW
Copy link

RalfWW commented Sep 4, 2015

The 2 accounts are still there.

I was able to re-adding the sync-folder at one account only. Server is a 8.1.1 fresh installation

But the other account is "working" but the listing of the available folders is not working. Server is a updated 8.1.1
I found out, that the connection to a remote WEBDAV-Server is not working.
After removing that definition (with path at /root) listing is working again.

@guruz There are no spezial characters in the root folder's names.

@tangix
Copy link
Author

tangix commented Sep 4, 2015

From my old config-file in C:\Users\msa.TANGIX\AppData\Local\ownCloud\owncloud.cfg.aE9772 I see that it is in fact the English version of the path used, but with standard slash:
[Accounts]
0\Folders\ownCloud\localPath=C:/Users/msa.TANGIX/ownCloud/

But after re-adding the synched folder I see in the new owncloud.cfg the path is escaped with double back-slash.
0\Folders\ownCloud\localPath=C:\Users\msa.TANGIX\ownCloud

@Siedlerchr
Copy link

I also have the same problem win 7 SP1 x64 German, and none of my paths contains any umlauts, but they contain spaces. But the two remaining folders also contain White spaces.
And the files in the remaining folders also contain Umlauts.

@ckamm
Copy link
Contributor

ckamm commented Sep 4, 2015

This is odd because there's only a single-line diff between 2.0.0 and 2.0.1 - and it's an unrelated wizard fix. Are you sure you were updating from the official 2.0.0 release to the 2.0.1 release?

@Siedlerchr
Copy link

@ckamm Yes, yesterday I got the notification and today I did the auto-update.
My prev version was : ownCloud-2.0.0.5423 and now my version is 2.01.5446

@individual-it
Copy link
Member

Same happened to me before the update on Linux.
Shut down the PC at work this evening, started it at home again. OC client started, showed a message that a new version is available but had lost all connections.

@vkimball
Copy link

vkimball commented Sep 5, 2015

Same thing happened to me on two different Windows PCs. One XP and the other Windows 7. Didn't happen on Mac or Ubuntu Linux updates.

@mikaelfrykholm
Copy link

The difference seems to be that the folders to sync is now in owncloud.cfg instead of folders/*

0\Folders\ownCloud\localPath=/home/mikael/ownCloud
0\Folders\ownCloud\targetPath=/ronin
0\Folders\ownCloud\paused=false
0\Folders\ownCloud\ignoreHiddenFiles=true

folders/ownCloud

[ownCloud]
localPath=/home/mikael/ownCloud
targetPath=/ronin
backend=owncloud
connection=ownCloud

@skimpax
Copy link

skimpax commented Sep 6, 2015

Idem for me: synced directory configuration was lost after upgrade to 2.0.1_5446 (was in official 2.0.0).
Did the upgrade just by clicking OK on upgrade notification.
Client on Win 7 Pro / 64bits / French

@tangix
Copy link
Author

tangix commented Sep 6, 2015

Just upgraded my other systems running Windows 7 64-bit and Win 8.1 64-bit, both running English OS versions. No problems at all, all settings kept.

@tjharman
Copy link

tjharman commented Sep 6, 2015

Windows 7 64-bit
Lost all folders on upgrade.

@guruz guruz added bug p2-high Escalation, on top of current planning, release blocker labels Sep 7, 2015
@guruz guruz added this to the 2.0.2-next milestone Sep 7, 2015
@dubsflyt
Copy link

I have also yesterday seen this same problem on 2.0.0, the only thing the user had done was rebooted the machine (some windows updates installed at the same time) and subsequently the sync folder config was wiped.

I have also seen it from every user who upgraded to 2.0.1 but only the one user on 2.0.0

@phil-davis
Copy link
Contributor

This happened to me only on my home laptop. It did an auto-update from 2.0.0 to 2.0.1 on Windows 10 and prompted me for admin priv... When ownCloud started again the account was there but no sync folder. I had to add the sync folder again.
On other systems I have done manual updates using the full downloaded installer and had no problem.
Is this problem only happening when the update is done with the auto-updater?

@guruz
Copy link
Contributor

guruz commented Sep 10, 2015

@phil-davis Interesting theory... but then i would have guessed the config-losing to be all or nothing, not keeping the sync URL

@Siedlerchr
Copy link

Interestingly on my Win7 32bit notebook, upgrading from 1.84 to 2.01 via autoupdate worked with no problems. All folders intact.

@dragotin
Copy link
Contributor

Can you guys check the old place where the folders resided ($HOME/.local/share/data/owncloud/folders for Unixoids) and paste the file names of the files residing there to this report?

@Siedlerchr
Copy link

@dragotin
In Windows it's placed under: C:\Users\AppData\Local\ownCloud
Edit// Both Windows Versions are Win 7 Pro German

FSR
LaTex
Rechnungen
UNI
Verwaltungsgedoens
WS1516 - Bacheloarbeit

Notebook:

BWL_WPR
DataMiningPythonStuff
FSR
LaTex
ownCloud
Rechnungen
Verwaltungsgedoens

@phil-davis
Copy link
Contributor

My home laptop Windows 10 just has a file called "ownCloud" in C:\Users\Davis\AppData\Local\ownCloud\folders
That file contains:

localPath=F:/Davis-ownCloud/
targetPath=/
backend=owncloud
connection=ownCloud

The thing is that I have already added back the same folder sync connection again as was there previously. So good evidence of what happened is probably gone for me.
Note that F: is a partition on the internal hard drive (after C:, D: an HP recovery partition and E: the DVD drive). So F: is always available.

@individual-it
Copy link
Member

for me in $HOME/.local/share/data/ownCloud/folders there is only one file called "owCloud"

content:

[ownCloud]
localPath=/home/xxxxx/OwnCloud/
targetPath=/
backend=owncloud
connection=ownCloud
blackList=@Invalid()

but before loosing the connections I had like 5 or 6 connections set up

@skimpax
Copy link

skimpax commented Sep 11, 2015

As said in mly prior comment, configuration lost after upgrade.
Locations of my configuration: C:\Users\chris\AppData\Local\ownCloud
Folders present in C:\Users\chris\AppData\Local\ownCloud\folders:

C:\Users\chris\AppData\Local\ownCloud\folders\Christophe :
[Christophe]
localPath=C:\ZzzData\Christophe
targetPath=/Christophe
backend=owncloud
connection=ownCloud
blackList=@invalid()

C:\Users\chris\AppData\Local\ownCloud\folders\Général :
[G%E9n%E9ral]
localPath=C:\ZzzData\G\xe9n\xe9ral
targetPath=/G\xe9n\xe9ral
backend=owncloud
connection=ownCloud
blackList=@invalid()

C:\Users\chris\AppData\Local\ownCloud\folders\Karine :
[Karine]
localPath=C:\ZzzData\Karine
targetPath=/Karine
backend=owncloud
connection=ownCloud
blackList=@invalid()

C:\Users\chris\AppData\Local\ownCloud\folders\Musiques :
[Musiques]
localPath=C:\Users\chris\Music
targetPath=/Musiques
backend=owncloud
connection=ownCloud
blackList=@invalid()

C:\Users\chris\AppData\Local\ownCloud\folders\Photos :
[Photos]
localPath=C:\Users\chris\Pictures
targetPath=/Photos
backend=owncloud
connection=ownCloud
blackList=@invalid()

C:\Users\chris\AppData\Local\ownCloud\folders\Pratique:
[Pratique]
localPath=C:\ZzzData\Pratique
targetPath=/Pratique
backend=owncloud
connection=ownCloud
blackList=@invalid()

Update done via auto-update mecanism by clicking on update available notification when poped-up. First time for me I used auto auto-update (always did update by classic downlown/install procedure before).
Issue due to interraction of update/install, with one done in Admin mode but the other in User mode?
Issue due to Locale special characters? (cf. my character 'é' in one of my folder)
Win 7 Pro / 64bits / French

@guruz
Copy link
Contributor

guruz commented Sep 13, 2015

@individual-it Are you implying this also happened on your Linux machine?

@individual-it
Copy link
Member

@guruz yes, see my first comment on that topic

@ckamm
Copy link
Contributor

ckamm commented Sep 18, 2015

When the client quits, the account settings are saved to the config file again (Application::slotCleanup). Maybe the configuration was wiped beforehand for some reason, or can't be read properly when that QSettings object sync()s. That'd explain account data being saved in the config file while folder data is missing.

@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Sep 18, 2015
@ckamm
Copy link
Contributor

ckamm commented Sep 18, 2015

Unfortunately this will happen again on the update from 2.0.1 to 2.0.2, because the bug was an unintended side-effect of the shutdown process after launching the updater. :(

@ckamm ckamm self-assigned this Sep 18, 2015
@Dianafg76 Dianafg76 removed the ReadyToTest QA, please validate the fix/enhancement label Sep 18, 2015
@ckamm
Copy link
Contributor

ckamm commented Sep 18, 2015

@Dianafg76 What's wrong?

@Dianafg76 Dianafg76 added the ReadyToTest QA, please validate the fix/enhancement label Sep 18, 2015
@Dianafg76
Copy link

@ckamm sorry

@Dianafg76
Copy link

I can't reproduce this issue with Win Server 2008 Enterprise.
@tangix, @RalfWW, @phil-davis Could you try, update from 2.0.1 to 2.0.2, please
Thanks

@tangix
Copy link
Author

tangix commented Sep 22, 2015

@Dianafg76 : just upgraded from 2.0.1 build 5446 to 2.0.2 build 5464 and my settings survived. No other problems detected. Windows 8.1 64-bit Swedish language.

@Dianafg76
Copy link

@tangix Many thanks

@Dianafg76 Dianafg76 removed the ReadyToTest QA, please validate the fix/enhancement label Sep 22, 2015
@phil-davis
Copy link
Contributor

I think this problem happened when the auto-updater ran automagically. Whenever I did a manual upgrade it worked fine between any versions.
I have installed 2.0.1 release from scratch on a test machine and set up some folder sync pairs.
Is there a way to trick the 2.0.1 client into finding a 2.0.2 update somewhere?

@ckamm
Copy link
Contributor

ckamm commented Sep 30, 2015

@phil-davis Yes, this was triggered only when the client started the updater binary and closed itself.

I think you can trick the client into thinking there's an update by manually adjusting some setting values, but I don't know what combination of settings is necessary exactly.

@dexternest
Copy link

Am I getting this right, that the issue was closed?
I had the same thing* happening to me today, when I let the owncloud client update itself to the newest version (2.0.2.5569).
But since I'm a newbie here, there might be something I'm not aware of?

*) "There are no sync folders configured"

@Gizmokid2005
Copy link

I, too, was just hit with this issue when Owncloud auto-updated on Win8.1 x64. The folders are all in C:\Users\Michael\AppData\Local\ownCloud\folders but not configured in the C:\Users\Michael\AppData\Local\ownCloud\owncloud.cfg and the client shows that there are no sync folders configured.

@dexternest
Copy link

I've opened a new issue, since this had been closed already: #4012

@gmonkey2
Copy link

Case may have been closed prematurely. Just upgraded a client from 2.0.1 5546 to 2.0.2 5569 and lost all of my sync data

@tjharman
Copy link

PEOPLE!! ARGH!
The issue is clear:

IF YOU LET OWNCLOUD UPGRADE FROM 2.0.0/2.0.1 to 2.0.2 BY ITSELF, you will almost certainly lose your sync folders.

THIS IS DUE TO A BUG IN 2.0.0/2.0.1. It doesn't matter if you later auto-upgrade to 3.8.4 THIS BUG WILL AFFECT YOU IF YOU ARE UPGRADING FROM 2.0.0/2.0.1.

Opening this ticket over and over is pointless. The issue is fixed in 2.0.2 so that when it upgrades itself, this won't happen.

You can't fix a bug that's already there, deployed to all the 2.0.0/2.0.1 clients. They have the bug and they trigger it when they upgrade to a newer version.

@dexternest
Copy link

Ok, THAT is an explanation.
The issue was NOT clear before.
THANKS!

@dragotin
Copy link
Contributor

Yes, it is exactly like that, unfortunately. Still no reason to get loud I'd say, but yes, thanks anyway for explaining.

@GeoSchnitz
Copy link

In that case, what's the best solution to avoid this issue.
Backup the AppData\Local\ownCloud files, deinstall versions 2.0.0/2.0.1, install 2.0.2 and copy back the cfg files and /folder configs?
Does this work because of different configurations-definitions?

@phil-davis
Copy link
Contributor

Backup your files - because you should have backup anyway :)
Manually download the 2.0.2 installer. Use that to run the upgrade manually.
That should avoid triggering the problem in 2.0/2.0.1
There should be no need to restore anything from backup.
For me, I never saw this bug on test systems where I had been doing manual installs/upgrades. It was only seen on clients that were allowed to auto-upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2-high Escalation, on top of current planning, release blocker sev1-critical
Projects
None yet
Development

No branches or pull requests