[backport] [stable8] always use an LDAP URL when connecting to LDAP

[blizzz]

Backport of #17924, cf. #17924 (comment)

Please test and review @PVince81 @MorrisJobke @owncloud/ldap

Oh, and give doublecare – the integration test cannot be backported, because those were only introduced into 8.1.

[mention-bot]

By analyzing the blame information on this pull request, we identified @LukasReschke, @MorrisJobke and @Xenopathic to be potential reviewers

[MorrisJobke]

@rperezb Can we have QA on this? Thanks

[MorrisJobke]

Tested and LDAP setup still works here 👍

[DeepDiver1975]

@owncloud/qa

[blizzz]

rebased

[MorrisJobke]

@owncloud/ldap @davitol @SergioBertolinSG This needs another reviewer ;)

[PVince81]

Somehow I can't reproduce the original issue. IIRC the issue was entering "localhost" instead of "ldap://localhost". But here both work on stable8.

@blizzz can you confirm ?

[blizzz]

@PVince81 Unfortunately,

This was independently observed by @MorrisJobke and @PVince81, but I cannot reproduce it on my system.

However, now in any case the connect should work in both wizard and normals usage, using the ldap:// protocol no matter whether you typed it or not. $host should always have protocol and port here https://github.com/owncloud/core/pull/21634/files#diff-e312bc894f109ef4a3a652b8db28734dR55 which is also the only place now for handling the connect parameters.

[PVince81]

Both variants "localhost" and "ldap://localhost" work for me on this branch. I checked that the users could be listed.

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.