Implemented #csrf_meta_tags #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation](#1127 (comment)) and will generate two meta tags one with the `csrf-param` your app is expecting and the other with the `csrf-token`. Fixes #1127 and #1251. - Added a csrf_param setting to allow you to tell what your CSRF token's field name should be when sent as a form parameter. It defaults to `authenticity_token`. `rack-protection` doesn't allow for that param to be set, so if you do so and want the middleware to work correctly you'll have to patch it or use your own validations for now - [see this](sinatra/rack-protection#65). - Refactored and cleaned up the CSRF helpers' code base and some helpers' tests.
|
A lot cleaner! Thanks @dariocravero. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and will generate two meta tags one with the
csrf-paramyour app isexpecting and the other with the
csrf-token. Fixes Add csrf_meta_tags for javascript helpers #1127 and WARN - attack prevented by Rack::Protection::AuthenticityToken #1251.field name should be when sent as a form parameter. It defaults to
authenticity_token.rack-protectiondoesn't allow for that param tobe set, so if you do so and want the middleware to work correctly you'll
have to patch it or use your own validations for now - see this.
helpers' tests.