Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement authenticity token #1541

Merged
merged 3 commits into from Dec 31, 2013
Merged

Conversation

namusyaka
Copy link
Contributor

ref #1539
I re-implemented AuthenticityToken.
/cc @skade @ujifgc

end

def call(env)
if @except && @except.call(env)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate an array or a regexp or a string as the except parameter. It would be an ease-of-use option I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll add support for proc parameter if proc is requested from users.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it could work with Proc, Array, Regexp, String.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it.

@namusyaka
Copy link
Contributor Author

done.

@skade
Copy link
Contributor

skade commented Dec 31, 2013

Thank you for the great work, btw.

Am 31.12.2013 um 14:17 schrieb namusyaka notifications@github.com:

done.


Reply to this email directly or view it on GitHub.

ujifgc added a commit that referenced this pull request Dec 31, 2013
@ujifgc ujifgc merged commit 733ec9d into master Dec 31, 2013
@ujifgc ujifgc deleted the reimplement-authenticity_token branch December 31, 2013 14:38
@namusyaka
Copy link
Contributor Author

@skade @ujifgc Thank you for the great advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants