Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractFormBuilder#fields_for should respect the builder of parent #1690

Merged
merged 1 commit into from Jun 1, 2014

Conversation

namusyaka
Copy link
Contributor

Now:

form_for(@user, '/register', builder: "AbstractFormBuilder") do |f|
  f #=> AbstractFormBuilder
  f.fields_for(:role_types, @user.role_types) do |field|
    field #=> StandardFormBuilder
    field.submit_block "Submit"
  end
end

I'd expected this:

form_for(@user, '/register', builder: "AbstractFormBuilder") do |f|
  f #=> AbstractFormBuilder
  f.fields_for(:role_types, @user.role_types) do |field|
    field #=> AbstractFormBuilder
    field.submit_block "Submit"
  end
end

@nesquena nesquena added this to the 0.12.3 milestone Jun 1, 2014
@nesquena
Copy link
Member

nesquena commented Jun 1, 2014

Nice, thanks!

nesquena added a commit that referenced this pull request Jun 1, 2014
AbstractFormBuilder#fields_for should respect the builder of parent
@nesquena nesquena merged commit d759e1b into master Jun 1, 2014
@nesquena nesquena deleted the builder-option branch June 1, 2014 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants