[padrino-gen] Adjust to RSpec3, and little fix #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the rake task: * remove the formatting option * add description to dynamic tasks * using 'each_with_object' instead of 'inject' to the templates: * adjust to RSpec3 syntax * set to be pending in the initial state
|
Thanks, looks good to me. |
| it "returns hello world" do | ||
| last_response.body.should == "Hello World" | ||
| it "http status code to be ok" do | ||
| expect(last_response).to be_ok |
There was a problem hiding this comment.
@tyabe Sorry, I overlooked this test. Has a different meaning between this test and other tests.
I guess this should probably be something like expect(last_response.body).to eq('Hello World').
There was a problem hiding this comment.
Yeah, that makes sense. I'll restore it.
|
@tyabe Thank you so much! |
namusyaka
added a commit
that referenced
this pull request
Jun 30, 2014
[padrino-gen] Adjust to RSpec3, and little fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the rake task:
to the templates: