Proposed Logger rework to fix issue 728

[skade]

Hi,

this evolved into a larger patch then intended, but hopefully satisfies all parties. I tried to refactor the Padrino Logger so that all the fancy stuff @DAddYE built is still working and - as an added bonus - can be added to other loggers as well. This works by splitting the logger implementation into 2 modules for proper extensions (like the #bench method for benchmarks and the #devel log level) and one for colorization (as some loggers, like syslog, cannot handle colors). Extensions are always added to any logger that is passed to #logger=, Colorization is only added on the users request. Example:

Padrino.logger = Lumberjack::Logger.new
Padrino.logger.colorize!
Padrino.logger.debug("Horay, a colorized Lumberjack logger!")

Also, I took the liberty of adding all those modules to a Padrino::Logging submodule, while keeping Padrino::Logger as is.

This pull request also adds tests using Lumberjack and the ruby stdlib Logger as examples.

Merry Christmas, by the way.

Best regards,
Florian

[nesquena]

Looks great, thanks for putting this together. @DAddYE can you review this and merge it since you've played with logging the most?

[DAddYE]

Sure @nesquena Im doing that now, many thanks to @skade !

[skade]

How about this one? I would really like to deploy Lumberjack in production.

[nesquena]

I agree @DAddYE Can you review and merge this before the release?

[DAddYE]

@nesquena sure, My apologies @skade for keeping you waiting.

[skade]

No reason to apologize :). But skipping one revision would be more work for everyone.

[DAddYE]

Thanks @skade I will re-couple into a single module to keep things more readable, btw awesome refactoring! Thanks so so much!