Padrino::Cache::Helpers::Page Content-Type Issue #745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why no one of these pull requests was merged? |
|
This one will be merged soon, thanks |
|
Merged: 8f746e0 Thanks! |
|
Why was this commit reverted? See sumskyi@732a31b I'm setting the content_type beforehand, but unfortunately it's no longer being sent back with the cached version. This breaks a compatibility issue I have with an iOS library (MMRecord) which expects a content-type of 'text/json' or similar. |
|
@joslinm judging by this commit, let's ask @DAddYE why it was changed like that. |
|
I also have difficulties caused by above revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store both response_buffer and content_type in cache; tests fix