Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Serf unittest failure outside USA because of redirect #265

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Closed

Serf unittest failure outside USA because of redirect #265

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Labels
auto-migrated Priority-Low release-note Type-Defect

Comments

@GoogleCodeExporter
Copy link 

SerfUrlAsyncFetcherTests fail outside of the US, because there, 
http://www.google.com/ 302-redirects to http://www.google.<CountryCode>/

This is not actually a problem, but the unittest fails.

[ RUN      ] SerfUrlAsyncFetcherTest.FetchOneURL
[0410/192627:INFO:net/instaweb/util/google_message_handler.cc(29)]
Initiating blocking fetch for http://www.google.com/
[0410/192628:INFO:net/instaweb/util/google_message_handler.cc(29)]
Fetch complete: http://www.google.com/
net/instaweb/apache/serf_url_async_fetcher_test.cc:167: Failure
Value of: response_headers_[idx]->status_code()
 Actual: 302
Expected: 200
net/instaweb/apache/serf_url_async_fetcher_test.cc:169: Failure
Value of: contents_[idx]->substr(0, content_starts_[idx].size())
 Actual: "<HTML><HEAD><me"
Expected: content_starts_[idx]
Which is: "<!doctype html>"
net/instaweb/apache/serf_url_async_fetcher_test.cc:243: Failure
Expected: (7500) < (bytes_count), actual: 7500 vs 218
[0410/192628:INFO:net/instaweb/apache/serf_url_async_fetcher.cc(457)]
Waiting for threaded serf fetcher to terminate
[  FAILED  ] SerfUrlAsyncFetcherTest.FetchOneURL (393 ms)

Original issue reported on code.google.com by sligocki@google.com on 11 Apr 2011 at 3:47
@GoogleCodeExporter
Copy link
Author 

This issue was closed by revision r811.

Original comment by sligocki@google.com on 7 Jul 2011 at 9:32

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by sligocki@google.com on 7 Jul 2011 at 9:34

  • Added labels: release-note

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-migrated Priority-Low release-note Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter