Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

VirtualHosts should inherit configuration from root #495

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments
Closed

VirtualHosts should inherit configuration from root #495

GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

It is more cumbersome that necessary to use MPS with virtual hosts.  I think we 
should add a configuration-merging function to pagespeed_module.  Note the TODO 
in that code now at the bottom of mod_instaweb.cc

  NULL,  // TODO(jmarantz): merge root/VirtualHost configs via merge_dir_config.


Duncan's suggestion is to have a new .conf directive which turns on 
configuration-merging.  This should be feasible.  We could also default-this to 
"off" in C++ and turn it on in the default pagespeed.conf so that new users get 
the easier-to-use version.

Original issue reported on code.google.com by jmara...@google.com on 14 Sep 2012 at 12:48

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 17 Sep 2012 at 7:30

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 17 Sep 2012 at 7:32

  • Added labels: Milestone-v23

@GoogleCodeExporter
Copy link
Author

Code in in r1978. Still need docs.

Original comment by morlov...@google.com on 25 Sep 2012 at 2:28

@GoogleCodeExporter
Copy link
Author

Docs staged (will be pushed once a version with the code is part of a release)

Original comment by morlov...@google.com on 5 Nov 2012 at 4:38

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant