Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Generalized PEP8 Enforcement #8317

Closed
chrisbyboston opened this issue Sep 19, 2014 · 2 comments
Closed

CLN: Generalized PEP8 Enforcement #8317

chrisbyboston opened this issue Sep 19, 2014 · 2 comments
Labels
Code Style Code style, linting, code_checks

Comments

@chrisbyboston
Copy link

Per @jorisvandenbossche (#8286 (comment)), we need to discuss a generalized way of enforcing PEP8 on the entire pandas code base.

Matplotlib has something similar here: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py, and here's the PR discussion: matplotlib/matplotlib#1945

Some discussion is probably needed on the PEP8 rules we're alright with ignoring as well as whether or not we want to use 80 or 100 lines for max-line-length (http://legacy.python.org/dev/peps/pep-0008/#maximum-line-length).

@jreback jreback added the Code Style Code style, linting, code_checks label Sep 19, 2014
@jreback jreback added this to the 0.15.1 milestone Sep 19, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@lexual
Copy link
Contributor

lexual commented Jun 4, 2015

Perhaps a tool such as yapf could be of use this area also?

https://github.com/google/yapf

@jreback
Copy link
Contributor

jreback commented Dec 30, 2015

closing in favor of #11928

@jreback jreback closed this as completed Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

No branches or pull requests

3 participants