Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and run through Travis CI #42

Open
leonsodhi opened this issue Jun 5, 2014 · 2 comments
Open

Add tests and run through Travis CI #42

leonsodhi opened this issue Jun 5, 2014 · 2 comments

Comments

@leonsodhi
Copy link

That would allow us to test new changes on multiple versions of Ruby and avoid situations where a method is called that doesn't exist. For example, here force_encoding doesn't exist on 1.8.7.

@lmarburger lmarburger self-assigned this Jun 5, 2014
@lmarburger lmarburger removed their assignment Sep 3, 2014
@DannyBen
Copy link
Contributor

DannyBen commented Aug 8, 2016

Is this on someone's near term agenda? It would make #78 a little easier in terms of confidence to make changes.

@troy
Copy link
Contributor

troy commented Aug 9, 2016

@DannyBen No plans in the foreseeable future. We're blessed with lots of really high-impact ways to improve Papertrail. Even as someone who loves great coverage, #78 is a low-impact improvement for the amount of time it would take, and other than that change, the codebase doesn't change much. Based on that, this wouldn't be a good use of time right now (nor would #78, but we're perfectly willing to let someone refactor if it strikes their fancy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants