Background text of attributed string does not work properly on High Sierra

[mischnic]

examples/text.js:

Expected (correct on Sierra):

High Sierra:

Need test whether this is an issue of libui.

[mischnic]

Need test whether this is an issue of libui.

Does the same happen if you run the libui drawtext example on High Sierra?

[parro-it]

No, but it seems it doesn't use background at all:

[mischnic]

4th Line: "text background color" has a yellow-ish background

Interesting. I can't reproduce this, unfortunately.

[parro-it]

Oh, yes. So it seems a bug on bindings...

[mischnic]

Oh, yes. So it seems a bug on bindings...

Then why does it work on Sierra? 😕

[parro-it]

Then why does it work on Sierra?

We should investigate 🕵🏻‍♂️

[mischnic]

I'd guess somewhere in here? After that, it's out of our control.

libui-node/src/Font/AttributedString.cc

Lines 70 to 79 in 4d72285

	void AttributedString::appendAttributedInternal(
	const char *str, std::vector<FontAttribute *> attrs) {
	size_t start = this->toStringLen();
	size_t end = start + strlen(str);
	this->appendUnattributed(str);
	for (std::vector<FontAttribute *>::size_type i = 0; i < attrs.size(); i++) {
	this->setAttribute(attrs[i], start, end);
	}
	}

Could you check if start and end are really the right values and whether the for loop properly iterates over the vector?

---

libui drawtext example:

static void appendWithAttribute(const char *what, uiAttribute *attr, uiAttribute *attr2)
{
	size_t start, end;

	start = uiAttributedStringLen(attrstr);
	end = start + strlen(what);
	uiAttributedStringAppendUnattributed(attrstr, what);
	uiAttributedStringSetAttribute(attrstr, attr, start, end);
	if (attr2 != NULL)
		uiAttributedStringSetAttribute(attrstr, attr2, start, end);
}

[mischnic]

Does it work correctly with libui-napi?

[parro-it]

No, it work the same as libui-node 😭