Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support .html.twig suffix #1030

Open
aleksip opened this issue Jul 10, 2019 · 10 comments · May be fixed by #1459
Open

Fully support .html.twig suffix #1030

aleksip opened this issue Jul 10, 2019 · 10 comments · May be fixed by #1459
Labels
help wanted 🆘 pinned 📌 Don't let stalebot clean this up

Comments

@aleksip
Copy link
Member

aleksip commented Jul 10, 2019

I am using Pattern Lab Node v3.0.1 on macOS, with Node v10.6.0, using the Twig Edition.

Expected Behavior

Use .html.twig suffix for patterns without any problems.

This style of suffix is advocated in Symfony documentation and is also used by Drupal. In some cases, e.g. when registering layout templates, Drupal expects the layout template to have a .html.twig suffix.

Actual Behavior

Twig template source/rendered HTML not shown in UI, possible other problems.

Steps to Reproduce

Use .html.twig suffix for patterns.

@stale
Copy link

stale bot commented Sep 8, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@aleksip
Copy link
Member Author

aleksip commented Sep 9, 2019

Hi there, stale bot!

@stale
Copy link

stale bot commented Nov 8, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@aleksip
Copy link
Member Author

aleksip commented Nov 8, 2019

Good old stale bot!

@stale
Copy link

stale bot commented Jan 7, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@backlineint
Copy link

I've also been tracking this issue. It is specifically problematic for layouts in Drupal 8 as @aleksip mentioned. I've done some work on a module that automatically derives layouts from a Pattern Lab instance (https://www.drupal.org/project/layouts_pattern_lab), but bug means that some workarounds are required in order to use this with the node version of Pattern Lab.

@stale
Copy link

stale bot commented Mar 7, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@backlineint
Copy link

Keeping this one alive...

@bmuenzenmeyer bmuenzenmeyer added help wanted 🆘 pinned 📌 Don't let stalebot clean this up labels Apr 14, 2020
@pcate-fls
Copy link

Has anyone found a workaround for this issue?

@mfranzke
Copy link
Contributor

mfranzke commented Feb 3, 2022

@aleksip are you using the extension ‚.html.twig‘ as a „mix and match“ with other files having the ‚.twig‘ as well in the same codebase, or are all of the files strictly named only in one of of those variations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 🆘 pinned 📌 Don't let stalebot clean this up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants