Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseTime is 20x slower than an attoparsec parser #47

Open
parsonsmatt opened this issue Jun 21, 2018 · 2 comments
Open

parseTime is 20x slower than an attoparsec parser #47

parsonsmatt opened this issue Jun 21, 2018 · 2 comments

Comments

@parsonsmatt
Copy link
Contributor

cf byteverse/chronos#18 (comment)

Currently mysql-simple uses parseTime to parse the time. Using a custom attoparsec parser would make things faster and more memory efficient.

@paul-rouse
Copy link
Owner

Chronos is interesting! Do you think the overall gain would be significant, in the context of the whole processing of a result?

@parsonsmatt
Copy link
Contributor Author

That's the important question :) I'll have to write a benchmark for it! Someone on FPChat mentioned that parsing UTCTime out of a database query was taking 20% of the runtime of his app, which got me on this chase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants