Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for dark mode toggle button tooltip #33

Open
9 of 11 tasks
pbaity opened this issue Apr 29, 2020 · 10 comments
Open
9 of 11 tasks

Add translations for dark mode toggle button tooltip #33

pbaity opened this issue Apr 29, 2020 · 10 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pbaity
Copy link
Owner

pbaity commented Apr 29, 2020

The tooltip for the dark mode toggle button is only in English and Russian. In any other language setting it stays in English.

It'd be great for users who are native speakers of the other languages offered in RocketChat to add translations to the tooltip to dark-mode-toggle.js. We need translations for:

NOTE: This list is not exhaustive. If your language is not in this list, please add it anyway!

P.S. Google Translate is not what we're looking for. "Toggle Dark Mode" isn't communicated the same in other languages. It'd be best for it the tooltip text to read naturally to native speakers, rather than a possibly robotic-sounding translation by Google.

@pbaity pbaity added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 29, 2020
@pbaity pbaity pinned this issue May 6, 2020
@y377
Copy link

y377 commented May 11, 2020

Can I take part in Chinese translation? Although mine is not very good, because I know rocket very well, I know what Chinese users need

@pbaity
Copy link
Owner Author

pbaity commented May 11, 2020

@rapliu Please do! The languages I listed above are the ones I found codes for in Rocket.Chat, but I'm sure that's not an exhaustive list. In dark-mode-toggle.js, in the const darkModeToggleText object, just add a line for Chinese and open a pull request.

Don't worry if it's not a perfect translation - if another Chinese-speaking user notices a problem with it, we can fix it then.

@pbaity
Copy link
Owner Author

pbaity commented Jul 23, 2020

@y377 Still interested in offering a Chinese translation?

@fdellwing
Copy link
Contributor

In German Dark Mode umschalten should be fine. We have not really a German term for dark mode.

@pbaity
Copy link
Owner Author

pbaity commented Aug 5, 2020

Thanks @fdellwing , added in #45

@aradhya-gupta
Copy link
Contributor

aradhya-gupta commented Sep 29, 2020

Although Hindi is not mentioned above, shall I add a Hindi translation for the tooltip?

@pbaity
Copy link
Owner Author

pbaity commented Sep 29, 2020

@aradhya-gupta Please do! I took the list above from this file in the RocketChat repository, but I think these are just the languages that support auto-translation. I'm adding Hindi to the list now.

@bseclier
Copy link

bseclier commented Dec 9, 2020

French traduction is : "Activer le mode sombre".

@pbaity
Copy link
Owner Author

pbaity commented Jan 12, 2021

Thanks @bseclier , after a long holiday break I added your translation in #102.

@y377
Copy link

y377 commented Apr 19, 2022

Yeah, I've been waiting for you to assign me something to translate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants