Add MacOS support #1045

Endle · 2024-01-31T01:34:03Z

Load libintl.8.dylib on mac
Check GTK schema

1) Load libintl.8.dylib on mac 2) Check GTK schema

dreua

I think this needs a quick test on windows, otherwise looks good to me, thanks for the contribution!

Would you like to add a few lines to the readme as well?

kbengs · 2024-02-02T17:21:34Z

It does not start on Windows because of check_gtk_schema_exists() . Is that needed on Linux and Windows?

Endle · 2024-02-02T17:40:05Z

Thank you. I don’t know the mechanism behind it. How about changing from raising an exception into printing a warning? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: kbengs ***@***.***> Sent: Friday, February 2, 2024 12:21:47 PM To: pdfarranger/pdfarranger ***@***.***> Cc: Zhenbo Li ***@***.***>; Author ***@***.***> Subject: Re: [pdfarranger/pdfarranger] Add MacOS support (PR #1045) It does not start on Windows because of check_gtk_schema_exists() . Is that needed on Linux and Windows? — Reply to this email directly, view it on GitHub<#1045 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYSQEIFMBX26YC26LDYZDLYRUOCXAVCNFSM6AAAAABCSHFMPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGMZTKOBRG4>. You are receiving this because you authored the thread.Message ID: ***@***.***>

kbengs · 2024-02-02T17:59:06Z

Yes I think so and run the check only on "Darwin", if it is a potential problem there?

dreua · 2024-02-11T10:54:15Z

pdfarranger/pdfarranger.py

+def get_libintl_path():
+    f = 'libintl.so.8'
+    if os.name == 'nt':
+        f = 'libintl-8'
+    if platform.system() == 'Darwin':
+        f = 'libintl.8.dylib'
+    return f


Can we get rid of the variable f here and return directly? Reorder the statements if overwriting was part of the logic but I guess that's not necessary here.
Also add an empty line after the function for readability.

dreua · 2024-02-11T10:58:47Z

pdfarranger/pdfarranger.py

+def check_gtk_schema_exists():
+    schemas = subprocess.run(["gsettings", "list-recursively"],
+        stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+        check=True,
+        text=True)
+    return 'org.gtk.Settings.ColorChooser' in schemas.stdout
+if not check_gtk_schema_exists():
+    raise Exception('Found no schema files. You may need to set GSETTINGS_SCHEMA_DIR.')


I totally understand that you added this to help/guide users with the same issue. However we don't want it to break stuff with tests that would be fine without therefore we should either:

Run it only on darwin if it is a common enough problem here

Make it a warning only. On windows where it is not supposed to work ever we still shouldn't run it because spamming warnings that are unfixable and not helpful are still a bad idea imo.

Feel free to do a combination of both.

Endle · 2024-02-11T15:55:50Z

Thank you @dreua

I totally agree with your comments. I'm sorry that I'm a bit distracted in this week. I'll modify my code and add a short note in the README when I have time.

pdfarranger/pdfarranger.py

dreua

Sorry for the late reply: We have another white space at end of line and an undefined Exception type. It would be nice to fix those warnings. Furthermore the tests are failing, we'd need to investigate that as well.

pdfarranger/pdfarranger.py

dreua · 2024-02-26T13:09:15Z

pdfarranger/pdfarranger.py

@@ -118,6 +126,23 @@
 from .config import Config
 from .core import Sides, _img_to_pdf

+def check_gtk_schema_exists():
+    # On Windows the GTK library has a different logic, so we're skipping the test
+    # See https://github.com/pdfarranger/pdfarranger/pull/1045/files#r1485570912 


Another trialing whitespace, just remove it. Many IDEs or editors have a setting to automatically strip or at least show it.

dreua · 2024-02-26T13:14:44Z

Could you rebase the branch on current main? Ideally also getting rid of the merge commits? Jerome recently changed something in the tests maybe that already fixes the failed test here.

kbengs · 2024-02-29T02:32:21Z

I still think this should be darwin only, .ie. if platform.system() == 'Darwin' and not check_gtk_schema_exists():

There is not much reason to run it on Linux. It will slow down upstart of application (by 37ms).

Endle · 2024-08-08T00:27:19Z

I'm sorry for my delay. I've updated my PR. May I ask for review it again?

@dreua

cerenno · 2024-08-14T20:14:42Z

Hello. Is it possible to make this into a dmg for mac? I tried all your instructions and can't get it to work. Have also been trying VMs in UTM to try to use it in Linux and can't get it to work. I'm really struggling with this. If there's anything you could do it would be greatly appreciated.

Endle · 2024-08-14T20:55:43Z

@cerenno How do you set up dev env on your mac? Nix/homebrew/macPort/etc.. ?

cerenno · 2024-08-14T21:06:30Z

@Endle I use homebrew. I'm not a programmer though. I've had a bit of help but didn't succeed in getting it to work. I think I managed to export the variables and stuff but when it came to using the pip/python there was no module for pdfarranger or similar errors along those lines.

Endle · 2024-08-14T21:57:03Z

@cerenno I don't use homebrew but I know it is the most popular option. I'll try to find a method to run pdfarranger with homebrew. Please give me a few days

cerenno · 2024-08-14T21:59:42Z

@Endle Alright. Thank you for taking the time to try. I'll wait for your response.

Endle · 2024-08-14T22:50:36Z

@cerenno can you try the following homebrew & pip dependencies?

git clone https://github.com/Endle/pdfarranger.git
cd pdfarranger; git checkout mac
brew install  pygobject3 gtk+3 poppler gettext
ln -s /opt/homebrew/lib/libintl.8.dylib .
pip3 install --user pikepdf PyGObject python-dateutil img2pdf
python3 -m pdfarranger

cerenno · 2024-08-15T02:17:56Z

@Endle Hello. Wow thank you so much! It worked seamlessly. I can't thank you enough for this. One question, for me to open it do I have to type on the terminal cd pdfarranger followed by ./setup.py build python3 -m pdfarranger everytime I want to use it or is there a way to automate it or make it into an icon that you can click and it opens?

Endle · 2024-08-17T14:06:28Z

@cerenno Sorry, I don't know packaging in macOS. And I don't know how to send a package request for homebrew (all I can find is https://github.com/orgs/Homebrew/discussions/533)

For now, I think you can set alias for pdfarranger

run echo $0 to tell if your terminal is bash or zsh (ref https://www.moncefbelyamani.com/which-shell-am-i-using-how-can-i-switch/)
If you're using bash, then edit ~/.bash_profile. If you're using zsh, edit ~/.zprofile
Add alias pa='cd xxx; python3 -m pdfarranger' into this file
restart the terminal

Now you should be able to just type pa to start pdfarranger

cerenno · 2024-08-22T23:55:43Z

Hello. Sorry for the delay. It didnt work and adding the alias adjustment makes the app not open, needing to reinstall with the git clone command. When using the command it says that theres no module named pdfarranger and directly after editing the alias, it said something like pdfarranger is an executable or something like that.

Add MacOS support

8a64894

1) Load libintl.8.dylib on mac 2) Check GTK schema

dreua reviewed Jan 31, 2024

View reviewed changes

dreua requested changes Feb 11, 2024

View reviewed changes

Endle added 5 commits February 16, 2024 19:44

Merge branch 'main' into mac

f65f602

Edit code following comments

f83c9ae

Add try-catch for subprocess

369de72

add readme

688499f

Edit readme

1c1a21f

Endle requested a review from dreua February 17, 2024 01:07

github-advanced-security bot found potential problems Feb 18, 2024

View reviewed changes

pdfarranger/pdfarranger.py Fixed Show resolved Hide resolved

pdfarranger/pdfarranger.py Dismissed Show dismissed Hide dismissed

dreua requested changes Feb 26, 2024

View reviewed changes

Endle added 4 commits March 1, 2024 12:51

Merge branch 'main' into mac

3936f3a

Add some comments

bfc4b45

Merge branch 'main' into mac_0807

a2d525a

Only detect gsettings on darwin

7100c90

Endle requested a review from dreua August 17, 2024 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MacOS support #1045

Add MacOS support #1045

Endle commented Jan 31, 2024

dreua left a comment •

edited

Loading

kbengs commented Feb 2, 2024

Endle commented Feb 2, 2024 via email

kbengs commented Feb 2, 2024

dreua Feb 11, 2024

dreua Feb 11, 2024

Endle commented Feb 11, 2024

dreua left a comment

dreua Feb 26, 2024

dreua commented Feb 26, 2024

kbengs commented Feb 29, 2024

Endle commented Aug 8, 2024

cerenno commented Aug 14, 2024

Endle commented Aug 14, 2024

cerenno commented Aug 14, 2024

Endle commented Aug 14, 2024

cerenno commented Aug 14, 2024

Endle commented Aug 14, 2024 •

edited

Loading

cerenno commented Aug 15, 2024

Endle commented Aug 17, 2024

cerenno commented Aug 22, 2024

Add MacOS support #1045

Are you sure you want to change the base?

Add MacOS support #1045

Conversation

Endle commented Jan 31, 2024

dreua left a comment • edited Loading

Choose a reason for hiding this comment

kbengs commented Feb 2, 2024

Endle commented Feb 2, 2024 via email

kbengs commented Feb 2, 2024

dreua Feb 11, 2024

Choose a reason for hiding this comment

dreua Feb 11, 2024

Choose a reason for hiding this comment

Endle commented Feb 11, 2024

dreua left a comment

Choose a reason for hiding this comment

dreua Feb 26, 2024

Choose a reason for hiding this comment

dreua commented Feb 26, 2024

kbengs commented Feb 29, 2024

Endle commented Aug 8, 2024

cerenno commented Aug 14, 2024

Endle commented Aug 14, 2024

cerenno commented Aug 14, 2024

Endle commented Aug 14, 2024

cerenno commented Aug 14, 2024

Endle commented Aug 14, 2024 • edited Loading

cerenno commented Aug 15, 2024

Endle commented Aug 17, 2024

cerenno commented Aug 22, 2024

dreua left a comment •

edited

Loading

Endle commented Aug 14, 2024 •

edited

Loading