Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils find implementation error #55

Open
pavlyuts opened this issue Nov 28, 2019 · 4 comments
Open

utils find implementation error #55

pavlyuts opened this issue Nov 28, 2019 · 4 comments

Comments

@pavlyuts
Copy link

Hi!

There an arror in the code of find method, class util. As a result, it returns NOT comma separated, but just concatenated results, leading to any usage failure.

the path:

--- a/<html>Util.php (<b>Today 9:21:05</b>)</html>
+++ b/<html><b>Current File</b></html>
@@ -457,8 +457,8 @@
                     $idList .= strtolower(
                         is_string($newId)
                         ? $newId
-                        : stream_get_contents($newId) . ','
-                    );
+                        : stream_get_contents($newId)
+                    ) . ',';
                 }
             } elseif (is_callable($criteria)) {
                 $idCache = array();
@boenrobot
Copy link
Member

Last I checked, this is already resolved in dev-develop.

@boenrobot boenrobot mentioned this issue Nov 28, 2019
Closed
@pavlyuts
Copy link
Author

Is it safe to use dev-develop in the producton?

@boenrobot
Copy link
Member

boenrobot commented Nov 28, 2019 •
edited

If you use a composer.lock file, sure.

I mean, new commits may come at any point, though at this point, I'm only doing minor fixes until I make an actual tagged release (which will happen when I can generate a new PHAR, which is a bit tricky...).

A composer.lock will ensure you stay at a particular commit that you've verified in a non-production environment.

@pavlyuts
Copy link
Author

Thanks, clear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boenrobot @pavlyuts