Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts autocomplete/suggest from PeeringDB when creating/editing a new AS #220

Open
mngan opened this issue Mar 30, 2020 · 5 comments
Open
Assignees
Labels
status: accepted type: enhancement Issue is considered as an enhancement to the code, so it is not a regression nor a blocking issue
Projects
Milestone

Comments

@mngan
Copy link
Contributor

mngan commented Mar 30, 2020

Environment

  • Python version:
  • Peering Manager version:

Proposed Functionality

When entering the contacts for a new AS, it would be helpful to suggest possible completions from the PeeringDB contact list.

Use Case

When creating new AS having some assistance filling in the contact details would be good, otherwise you have to fill it in afterwards by flipping back and forth between two tabs.

I have gotten around this by writing a tool using the REST API to pull the PDB contact into the Peering Manager contact.

External Dependencies

None.

@gmazoyer gmazoyer self-assigned this Mar 30, 2020
@gmazoyer gmazoyer added the type: enhancement Issue is considered as an enhancement to the code, so it is not a regression nor a blocking issue label Mar 30, 2020
@netravnen
Copy link
Contributor

netravnen commented Mar 30, 2020 via email

@mngan
Copy link
Contributor Author

mngan commented Mar 30, 2020

All the data is already in the peeringdb_contact table if you have synced the PeeringDB database with an authorized account. If the data is missing from this table, then that should not affect the autocomplete. The only thing missing is the connection from the form to the peeringdb_contact table.

@gmazoyer
Copy link
Member

gmazoyer commented Apr 4, 2020

Maybe it is time to make contacts a first class citizen inside Peering Manager as well. Instead of having the possibility to register only one contact or use the one from PeeringDB, we could create a new Contact class and create a one-to-many relationship between an AS and a contact.

@netravnen
Copy link
Contributor

we could create a new Contact class and create a one-to-many relationship between an AS and a contact.

Will makes sense to deduplicate data when possible. (The primary reason, from my perspective, is for the organizations in PeeringDB, which manages several networks (also known as ASN's) and can often have identical contact information)

@gmazoyer gmazoyer added this to the v2.0 milestone Oct 11, 2020
@gmazoyer gmazoyer added this to To do in Third Party via automation Apr 28, 2021
@stale stale bot added the status: wontfix Not an issue, no fix to be done, no code to be changed label Jul 12, 2021
@peering-manager peering-manager deleted a comment from stale bot Jul 12, 2021
@stale stale bot removed the status: wontfix Not an issue, no fix to be done, no code to be changed label Jul 12, 2021
@jaakub
Copy link

jaakub commented Oct 22, 2021

Maybe it is time to make contacts a first class citizen inside Peering Manager as well. Instead of having the possibility to register only one contact or use the one from PeeringDB, we could create a new Contact class and create a one-to-many relationship between an AS and a contact.

We'd also like to see the ability to create multiple contacts for a single ASN - both manually but also via auto-complete (although not so important to us since we'd only create a manual ASN entry if the 3rd party does not have a valid PeeringDB record).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted type: enhancement Issue is considered as an enhancement to the code, so it is not a regression nor a blocking issue
Projects
Development

No branches or pull requests

4 participants