Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "How-To-Test" to the description #3305

Open
joleaf opened this issue May 4, 2023 · 1 comment
Open

Add an "How-To-Test" to the description #3305

joleaf opened this issue May 4, 2023 · 1 comment

Comments

@joleaf
Copy link
Contributor

joleaf commented May 4, 2023

Hey,
in the Readme.md it says "test your changes with a local checkout of the site.". However, you need to deploy the project to an apache server to test it correctly. My suggestion: Add a Dockerfile
e.g.:

FROM httpd:alpine

RUN sed -i '/LoadModule rewrite_module/s/^#//g' /usr/local/apache2/conf/httpd.conf && \
    sed -i 's#AllowOverride [Nn]one#AllowOverride All#' /usr/local/apache2/conf/httpd.conf

WORKDIR /usr/local/apache2/htdocs/

COPY . .

... to this repo and a command...

docker build -t temp . && docker run -i -p 3000:80 -v $PWD:/usr/local/apache2/htdocs/ temp   

to start a server on localhost.
This makes testing things ease. Or are there other ways to test this project?

Best,
Jo

@davidlehn
Copy link
Collaborator

Thanks. It was on my todo list to add a dev Dockerfile. I had tried something similar long ago but never polished it up. I've always used a local apache server setup to test, but I know a Docker solution would be easier for most people. We'll add something like the above once #3264 is done so Docker files don't get mixed up with regular served files.

Related: #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants