Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing PyPlot dependency #36

Closed
nlw0 opened this issue Mar 29, 2023 · 2 comments
Closed

Removing PyPlot dependency #36

nlw0 opened this issue Mar 29, 2023 · 2 comments

Comments

@nlw0
Copy link
Collaborator

nlw0 commented Mar 29, 2023

Despite the amazing work that has been done integrating Julia with Python and Matplotlib, it is unfortunately a tricky thing to get it to work. Automatic installation is just not reliable. And as noted in the Readme, this can be greatly inconvenient. I would propose to remove the dependency on PyPlot. I can prepare a patch, but it would be great to have some directions about what to do with the existing code that depends on it. Some "demo" code might simply not be included in the module, what I think it's already the case for some of the files, but some functions have plotting features deep inside them, at it'll be hard to refactor that out. Can I simply go on removing any plotting code from these cases?

I have these changes in my fork, I didn't want to make a PR before having a talk. https://github.com/nlw0/ImageProjectiveGeometry.jl

@nlw0 nlw0 changed the title PyPlot dependency Removing PyPlot dependency Mar 29, 2023
@peterkovesi
Copy link
Owner

You are most welcome to make a PR. However there may be a case for some plotting to remain using some other plotting library in some cases, we can discuss this with your PR

It would be good to remove the dependency of PyPlot as I agree that it can be troublesome. The presence of PyPlot in the code is somewhat historical. I started developing the code back when Julia was at 0.5 - 0.6 and the plotting options were a bit limited. It the time PyPlot was one of the few that offered full 3D plotting and also the ability to overlay plots over images, and Matplotlib was mature. Things have changed now.

Note also that I am retired and now find myself not writing any code there days. My maintenance of these repositories is minimal at best.

@nlw0
Copy link
Collaborator Author

nlw0 commented Jun 5, 2023

Ok, I created #37 . I completely understand having plotting mixed with the code... And I only started using Julia because matplotlib integration was so good!

@nlw0 nlw0 closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants